Incorrect dashed and dotted border painting.
authorzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 22 Dec 2014 23:18:59 +0000 (23:18 +0000)
committerzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 22 Dec 2014 23:18:59 +0000 (23:18 +0000)
commit95b496f9e2af229eb9b52a11fb16aa692f2e444b
treef00df48e90f88582ce6cd09f80320d6e0eeaba9d
parent15e94b106cc77006f4999733a04ab62b57329997
Incorrect dashed and dotted border painting.
https://bugs.webkit.org/show_bug.cgi?id=139872
rdar://problem/18024205

Reviewed by Simon Fraser.

This patch makes dashed/dotted border painting symmetric and consistent.
It also works with subpixel positioning.

Source/WebCore:

Tests: fast/borders/border-painting-correctness-dashed.html
       fast/borders/border-painting-correctness-dotted.html

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLine):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):

LayoutTests:

* fast/borders/border-painting-correctness-dashed-expected.html: Added.
* fast/borders/border-painting-correctness-dashed.html: Added.
* fast/borders/border-painting-correctness-dotted-expected.html: Added.
* fast/borders/border-painting-correctness-dotted.html: Added.
* fast/borders/resources/border-painting-correctness-dashed-expected.png: Added.
* fast/borders/resources/border-painting-correctness-dotted-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/borders/border-painting-correctness-dashed-expected.html [new file with mode: 0644]
LayoutTests/fast/borders/border-painting-correctness-dashed.html [new file with mode: 0644]
LayoutTests/fast/borders/border-painting-correctness-dotted-expected.html [new file with mode: 0644]
LayoutTests/fast/borders/border-painting-correctness-dotted.html [new file with mode: 0644]
LayoutTests/fast/borders/resources/border-painting-correctness-dashed-expected.png [new file with mode: 0644]
LayoutTests/fast/borders/resources/border-painting-correctness-dotted-expected.png [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
Source/WebCore/rendering/RenderObject.cpp