WebCore:
authoradele@apple.com <adele@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 16 Nov 2007 07:00:50 +0000 (07:00 +0000)
committeradele@apple.com <adele@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 16 Nov 2007 07:00:50 +0000 (07:00 +0000)
commit92ba495e88768e1a85afb79667cda16b6f4c70bb
treea8cfff0efde3726e344661d80bcd060f81b3bbda
parent484648a5c08eaf0f8a9447651f339921797f30d6
WebCore:

        Reviewed by Oliver.

        Fix for <rdar://problem/5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)

        Test: fast/forms/menulist-no-renderer-onmousedown.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::defaultEventHandler): Nil check the renderer here.  None of the default behavior makes sense if there's no renderer.
        (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Moved the nil check to the main defaultEventHandler.

LayoutTests:

        Reviewed by Oliver.

        Test for <rdar://problem/5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)

        * fast/forms/menulist-no-renderer-onmousedown-expected.txt: Added.
        * fast/forms/menulist-no-renderer-onmousedown.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/forms/menulist-no-renderer-onmousedown-expected.txt [new file with mode: 0644]
LayoutTests/fast/forms/menulist-no-renderer-onmousedown.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/html/HTMLSelectElement.cpp