Remove LegacyProfiler
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 21 May 2016 02:00:42 +0000 (02:00 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 21 May 2016 02:00:42 +0000 (02:00 +0000)
commit905fb215251c77b9d7cdd6b3fdbbfc73f5d1d0c7
tree3c1b9f144dda14476c36c38ca4dab4c1dc0aca09
parent7e695c18f1761bebf38d14908029e65b16752649
Remove LegacyProfiler
https://bugs.webkit.org/show_bug.cgi?id=153565

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-05-20
Reviewed by Saam Barati.

.:

* ManualTests/inspector/profiler-test-call.html: Removed.
* ManualTests/inspector/profiler-test-many-calls-in-the-same-scope.html: Removed.

Source/JavaScriptCore:

* inspector/protocol/Timeline.json:
* jsc.cpp:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::hasLegacyProfiler):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::supportsLegacyProfiling): Deleted.

Source/WebCore:

JavaScriptCore now provides a sampling profiler and it is enabled
by all ports. Web Inspector switched months ago to using the
sampling profiler and displaying its data. Remove the legacy
profiler, as it is no longer being used by anything other then
console.profile and tests. We will update console.profile's
behavior soon to have new behavior and use the sampling data.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* ForwardingHeaders/profiler/LegacyProfiler.h: Removed.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCustomXPathNSResolver.cpp:
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsLegacyProfiling): Deleted.
(WebCore::JSDOMWindowBase::supportsRichSourceInfo): Deleted.
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::supportsLegacyProfiling): Deleted.
* bindings/js/JSWorkerGlobalScopeBase.h:
* bindings/js/ScriptCachedFrameData.cpp:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell): Deleted.
* bindings/js/ScriptProfile.h: Removed.
* bindings/js/ScriptProfileNode.h: Removed.
* bindings/scripts/CodeGeneratorJS.pm:
(AddClassForwardIfNeeded): Deleted.
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence): Deleted.
* bindings/scripts/test/TestObj.idl:
* css/CSSParser.cpp:
* dom/Document.cpp:
* inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::stopProfiling):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::legacyProfilerEnabled): Deleted.
(WebCore::InspectorController::setLegacyProfilerEnabled): Deleted.
* inspector/InspectorController.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::stopProfilingImpl):
* inspector/InspectorInstrumentation.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
* inspector/InspectorTimelineAgent.h:
* inspector/PageDebuggerAgent.cpp:
* inspector/PageRuntimeAgent.cpp:
* inspector/ScriptProfile.idl: Removed.
* inspector/ScriptProfileNode.idl: Removed.
* inspector/TimelineRecordFactory.cpp:
(WebCore::buildAggregateCallInfoInspectorObject): Deleted.
(WebCore::buildInspectorObject): Deleted.
(WebCore::buildProfileInspectorObject): Deleted.
(WebCore::TimelineRecordFactory::appendProfile): Deleted.
* inspector/TimelineRecordFactory.h:
* page/DOMWindow.cpp:
* page/Page.cpp:
* page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::profileEnd):
(WebCore::PageConsoleClient::clearProfiles): Deleted.
* page/PageConsoleClient.h:
* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Deleted.
(WebCore::Internals::consoleProfiles): Deleted.
(WebCore::Internals::setLegacyJavaScriptProfilingEnabled): Deleted.
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit/win:

* Interfaces/IWebInspector.idl:
* WebCoreStatistics.cpp:
* WebInspector.cpp:
(WebInspector::isJavaScriptProfilingEnabled): Deleted.
(WebInspector::setJavaScriptProfilingEnabled): Deleted.
* WebInspector.h:
* WebView.cpp:

LayoutTests:

* fast/profiler/anonymous-event-handler-expected.txt: Removed.
* fast/profiler/anonymous-event-handler.html: Removed.
* fast/profiler/anonymous-function-called-from-different-contexts-expected.txt: Removed.
* fast/profiler/anonymous-function-called-from-different-contexts.html: Removed.
* fast/profiler/anonymous-function-calls-built-in-functions-expected.txt: Removed.
* fast/profiler/anonymous-function-calls-built-in-functions.html: Removed.
* fast/profiler/anonymous-function-calls-eval-expected.txt: Removed.
* fast/profiler/anonymous-function-calls-eval.html: Removed.
* fast/profiler/anonymous-functions-with-display-names-expected.txt: Removed.
* fast/profiler/anonymous-functions-with-display-names.html: Removed.
* fast/profiler/apply-expected.txt: Removed.
* fast/profiler/apply.html: Removed.
* fast/profiler/built-in-function-calls-anonymous-expected.txt: Removed.
* fast/profiler/built-in-function-calls-anonymous.html: Removed.
* fast/profiler/built-in-function-calls-user-defined-function-expected.txt: Removed.
* fast/profiler/built-in-function-calls-user-defined-function.html: Removed.
* fast/profiler/call-expected.txt: Removed.
* fast/profiler/call-register-leak-expected.txt: Removed.
* fast/profiler/call-register-leak.html: Removed.
* fast/profiler/call.html: Removed.
* fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt: Removed.
* fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
* fast/profiler/compare-multiple-profiles-expected.txt: Removed.
* fast/profiler/compare-multiple-profiles.html: Removed.
* fast/profiler/constructor-expected.txt: Removed.
* fast/profiler/constructor.html: Removed.
* fast/profiler/dead-time-expected.txt: Removed.
* fast/profiler/dead-time.html: Removed.
* fast/profiler/document-dot-write-expected.txt: Removed.
* fast/profiler/document-dot-write.html: Removed.
* fast/profiler/event-handler-expected.txt: Removed.
* fast/profiler/event-handler.html: Removed.
* fast/profiler/execution-context-and-eval-on-same-line-expected.txt: Removed.
* fast/profiler/execution-context-and-eval-on-same-line.html: Removed.
* fast/profiler/inline-event-handler-expected.txt: Removed.
* fast/profiler/inline-event-handler.html: Removed.
* fast/profiler/many-calls-in-the-same-scope-expected.txt: Removed.
* fast/profiler/many-calls-in-the-same-scope.html: Removed.
* fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt: Removed.
* fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Removed.
* fast/profiler/multiple-and-different-scoped-function-calls-expected.txt: Removed.
* fast/profiler/multiple-and-different-scoped-function-calls.html: Removed.
* fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt: Removed.
* fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html: Removed.
* fast/profiler/multiple-frames-expected.txt: Removed.
* fast/profiler/multiple-frames.html: Removed.
* fast/profiler/named-functions-with-display-names-expected.txt: Removed.
* fast/profiler/named-functions-with-display-names.html: Removed.
* fast/profiler/nested-anonymous-functon-expected.txt: Removed.
* fast/profiler/nested-anonymous-functon.html: Removed.
* fast/profiler/nested-start-and-stop-profiler-expected.txt: Removed.
* fast/profiler/nested-start-and-stop-profiler.html: Removed.
* fast/profiler/no-execution-context-expected.txt: Removed.
* fast/profiler/no-execution-context.html: Removed.
* fast/profiler/one-execution-context-expected.txt: Removed.
* fast/profiler/one-execution-context.html: Removed.
* fast/profiler/profile-calls-in-included-file-expected.txt: Removed.
* fast/profiler/profile-calls-in-included-file.html: Removed.
* fast/profiler/profile-with-no-title-expected.txt: Removed.
* fast/profiler/profile-with-no-title.html: Removed.
* fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Removed.
* fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
* fast/profiler/profiling-from-a-nested-location-expected.txt: Removed.
* fast/profiler/profiling-from-a-nested-location.html: Removed.
* fast/profiler/resources/other-frame.html: Removed.
* fast/profiler/resources/other-window.html: Removed.
* fast/profiler/resources/profiler-test-JS-resources.js: Removed.
* fast/profiler/simple-event-call-expected.txt: Removed.
* fast/profiler/simple-event-call.html: Removed.
* fast/profiler/simple-no-level-change-expected.txt: Removed.
* fast/profiler/simple-no-level-change.html: Removed.
* fast/profiler/start-and-stop-profiler-multiple-times-expected.txt: Removed.
* fast/profiler/start-and-stop-profiler-multiple-times.html: Removed.
* fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt: Removed.
* fast/profiler/start-and-stop-profiling-in-the-same-function.html: Removed.
* fast/profiler/start-but-dont-stop-profiling-expected.txt: Removed.
* fast/profiler/start-but-dont-stop-profiling.html: Removed.
* fast/profiler/stop-profiling-after-setTimeout-expected.txt: Removed.
* fast/profiler/stop-profiling-after-setTimeout.html: Removed.
* fast/profiler/stop-then-function-call-expected.txt: Removed.
* fast/profiler/stop-then-function-call.html: Removed.
* fast/profiler/throw-exception-from-eval-expected.txt: Removed.
* fast/profiler/throw-exception-from-eval.html-disabled: Removed.
* fast/profiler/two-execution-contexts-expected.txt: Removed.
* fast/profiler/two-execution-contexts.html: Removed.
* fast/profiler/user-defined-function-calls-built-in-functions-expected.txt: Removed.
* fast/profiler/user-defined-function-calls-built-in-functions.html: Removed.
* fast/profiler/window-dot-eval-expected.txt: Removed.
* fast/profiler/window-dot-eval.html: Removed.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/ios-simulator/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@201237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
147 files changed:
ChangeLog
LayoutTests/ChangeLog
LayoutTests/fast/profiler/anonymous-event-handler-expected.txt [deleted file]
LayoutTests/fast/profiler/anonymous-event-handler.html [deleted file]
LayoutTests/fast/profiler/anonymous-function-called-from-different-contexts-expected.txt [deleted file]
LayoutTests/fast/profiler/anonymous-function-called-from-different-contexts.html [deleted file]
LayoutTests/fast/profiler/anonymous-function-calls-built-in-functions-expected.txt [deleted file]
LayoutTests/fast/profiler/anonymous-function-calls-built-in-functions.html [deleted file]
LayoutTests/fast/profiler/anonymous-function-calls-eval-expected.txt [deleted file]
LayoutTests/fast/profiler/anonymous-function-calls-eval.html [deleted file]
LayoutTests/fast/profiler/anonymous-functions-with-display-names-expected.txt [deleted file]
LayoutTests/fast/profiler/anonymous-functions-with-display-names.html [deleted file]
LayoutTests/fast/profiler/apply-expected.txt [deleted file]
LayoutTests/fast/profiler/apply.html [deleted file]
LayoutTests/fast/profiler/built-in-function-calls-anonymous-expected.txt [deleted file]
LayoutTests/fast/profiler/built-in-function-calls-anonymous.html [deleted file]
LayoutTests/fast/profiler/built-in-function-calls-user-defined-function-expected.txt [deleted file]
LayoutTests/fast/profiler/built-in-function-calls-user-defined-function.html [deleted file]
LayoutTests/fast/profiler/call-expected.txt [deleted file]
LayoutTests/fast/profiler/call-register-leak-expected.txt [deleted file]
LayoutTests/fast/profiler/call-register-leak.html [deleted file]
LayoutTests/fast/profiler/call.html [deleted file]
LayoutTests/fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt [deleted file]
LayoutTests/fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html [deleted file]
LayoutTests/fast/profiler/compare-multiple-profiles-expected.txt [deleted file]
LayoutTests/fast/profiler/compare-multiple-profiles.html [deleted file]
LayoutTests/fast/profiler/constructor-expected.txt [deleted file]
LayoutTests/fast/profiler/constructor.html [deleted file]
LayoutTests/fast/profiler/dead-time-expected.txt [deleted file]
LayoutTests/fast/profiler/dead-time.html [deleted file]
LayoutTests/fast/profiler/document-dot-write-expected.txt [deleted file]
LayoutTests/fast/profiler/document-dot-write.html [deleted file]
LayoutTests/fast/profiler/event-handler-expected.txt [deleted file]
LayoutTests/fast/profiler/event-handler.html [deleted file]
LayoutTests/fast/profiler/execution-context-and-eval-on-same-line-expected.txt [deleted file]
LayoutTests/fast/profiler/execution-context-and-eval-on-same-line.html [deleted file]
LayoutTests/fast/profiler/inline-event-handler-expected.txt [deleted file]
LayoutTests/fast/profiler/inline-event-handler.html [deleted file]
LayoutTests/fast/profiler/many-calls-in-the-same-scope-expected.txt [deleted file]
LayoutTests/fast/profiler/many-calls-in-the-same-scope.html [deleted file]
LayoutTests/fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt [deleted file]
LayoutTests/fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html [deleted file]
LayoutTests/fast/profiler/multiple-and-different-scoped-function-calls-expected.txt [deleted file]
LayoutTests/fast/profiler/multiple-and-different-scoped-function-calls.html [deleted file]
LayoutTests/fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt [deleted file]
LayoutTests/fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html [deleted file]
LayoutTests/fast/profiler/multiple-frames-expected.txt [deleted file]
LayoutTests/fast/profiler/multiple-frames.html [deleted file]
LayoutTests/fast/profiler/named-functions-with-display-names-expected.txt [deleted file]
LayoutTests/fast/profiler/named-functions-with-display-names.html [deleted file]
LayoutTests/fast/profiler/nested-anonymous-functon-expected.txt [deleted file]
LayoutTests/fast/profiler/nested-anonymous-functon.html [deleted file]
LayoutTests/fast/profiler/nested-start-and-stop-profiler-expected.txt [deleted file]
LayoutTests/fast/profiler/nested-start-and-stop-profiler.html [deleted file]
LayoutTests/fast/profiler/no-execution-context-expected.txt [deleted file]
LayoutTests/fast/profiler/no-execution-context.html [deleted file]
LayoutTests/fast/profiler/one-execution-context-expected.txt [deleted file]
LayoutTests/fast/profiler/one-execution-context.html [deleted file]
LayoutTests/fast/profiler/profile-calls-in-included-file-expected.txt [deleted file]
LayoutTests/fast/profiler/profile-calls-in-included-file.html [deleted file]
LayoutTests/fast/profiler/profile-with-no-title-expected.txt [deleted file]
LayoutTests/fast/profiler/profile-with-no-title.html [deleted file]
LayoutTests/fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt [deleted file]
LayoutTests/fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html [deleted file]
LayoutTests/fast/profiler/profiling-from-a-nested-location-expected.txt [deleted file]
LayoutTests/fast/profiler/profiling-from-a-nested-location.html [deleted file]
LayoutTests/fast/profiler/resources/other-frame.html [deleted file]
LayoutTests/fast/profiler/resources/other-window.html [deleted file]
LayoutTests/fast/profiler/resources/profiler-test-JS-resources.js [deleted file]
LayoutTests/fast/profiler/simple-event-call-expected.txt [deleted file]
LayoutTests/fast/profiler/simple-event-call.html [deleted file]
LayoutTests/fast/profiler/simple-no-level-change-expected.txt [deleted file]
LayoutTests/fast/profiler/simple-no-level-change.html [deleted file]
LayoutTests/fast/profiler/start-and-stop-profiler-multiple-times-expected.txt [deleted file]
LayoutTests/fast/profiler/start-and-stop-profiler-multiple-times.html [deleted file]
LayoutTests/fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt [deleted file]
LayoutTests/fast/profiler/start-and-stop-profiling-in-the-same-function.html [deleted file]
LayoutTests/fast/profiler/start-but-dont-stop-profiling-expected.txt [deleted file]
LayoutTests/fast/profiler/start-but-dont-stop-profiling.html [deleted file]
LayoutTests/fast/profiler/stop-profiling-after-setTimeout-expected.txt [deleted file]
LayoutTests/fast/profiler/stop-profiling-after-setTimeout.html [deleted file]
LayoutTests/fast/profiler/stop-then-function-call-expected.txt [deleted file]
LayoutTests/fast/profiler/stop-then-function-call.html [deleted file]
LayoutTests/fast/profiler/throw-exception-from-eval-expected.txt [deleted file]
LayoutTests/fast/profiler/throw-exception-from-eval.html-disabled [deleted file]
LayoutTests/fast/profiler/two-execution-contexts-expected.txt [deleted file]
LayoutTests/fast/profiler/two-execution-contexts.html [deleted file]
LayoutTests/fast/profiler/user-defined-function-calls-built-in-functions-expected.txt [deleted file]
LayoutTests/fast/profiler/user-defined-function-calls-built-in-functions.html [deleted file]
LayoutTests/fast/profiler/window-dot-eval-expected.txt [deleted file]
LayoutTests/fast/profiler/window-dot-eval.html [deleted file]
LayoutTests/platform/efl/TestExpectations
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/ios-simulator/TestExpectations
ManualTests/inspector/profiler-test-call.html [deleted file]
ManualTests/inspector/profiler-test-many-calls-in-the-same-scope.html [deleted file]
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/inspector/protocol/Timeline.json
Source/JavaScriptCore/jsc.cpp
Source/JavaScriptCore/runtime/JSGlobalObject.cpp
Source/JavaScriptCore/runtime/JSGlobalObject.h
Source/WebCore/CMakeLists.txt
Source/WebCore/ChangeLog
Source/WebCore/DerivedSources.cpp
Source/WebCore/DerivedSources.make
Source/WebCore/ForwardingHeaders/profiler/LegacyProfiler.h [deleted file]
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/bindings/js/JSCustomXPathNSResolver.cpp
Source/WebCore/bindings/js/JSDOMWindowBase.cpp
Source/WebCore/bindings/js/JSDOMWindowBase.h
Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp
Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h
Source/WebCore/bindings/js/ScriptCachedFrameData.cpp
Source/WebCore/bindings/js/ScriptController.cpp
Source/WebCore/bindings/js/ScriptProfile.h [deleted file]
Source/WebCore/bindings/js/ScriptProfileNode.h [deleted file]
Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
Source/WebCore/bindings/scripts/test/TestObj.idl
Source/WebCore/css/CSSParser.cpp
Source/WebCore/dom/Document.cpp
Source/WebCore/inspector/InspectorConsoleInstrumentation.h
Source/WebCore/inspector/InspectorController.cpp
Source/WebCore/inspector/InspectorController.h
Source/WebCore/inspector/InspectorInstrumentation.cpp
Source/WebCore/inspector/InspectorInstrumentation.h
Source/WebCore/inspector/InspectorTimelineAgent.cpp
Source/WebCore/inspector/InspectorTimelineAgent.h
Source/WebCore/inspector/PageDebuggerAgent.cpp
Source/WebCore/inspector/PageRuntimeAgent.cpp
Source/WebCore/inspector/ScriptProfile.idl [deleted file]
Source/WebCore/inspector/ScriptProfileNode.idl [deleted file]
Source/WebCore/inspector/TimelineRecordFactory.cpp
Source/WebCore/inspector/TimelineRecordFactory.h
Source/WebCore/page/DOMWindow.cpp
Source/WebCore/page/Page.cpp
Source/WebCore/page/PageConsoleClient.cpp
Source/WebCore/page/PageConsoleClient.h
Source/WebCore/testing/Internals.cpp
Source/WebCore/testing/Internals.h
Source/WebCore/testing/Internals.idl
Source/WebKit/win/ChangeLog
Source/WebKit/win/Interfaces/IWebInspector.idl
Source/WebKit/win/WebCoreStatistics.cpp
Source/WebKit/win/WebInspector.cpp
Source/WebKit/win/WebInspector.h
Source/WebKit/win/WebView.cpp