WebCore:
authorbdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 3 Jul 2008 00:10:13 +0000 (00:10 +0000)
committerbdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 3 Jul 2008 00:10:13 +0000 (00:10 +0000)
commit8f306d1bfa54b6b82664935410b6a8b33eb9197d
treed5a8dfaabf8467b24c5fe910dd357ae1e651082b
parent2b3eb4f65f2bc008e64dd9dd00cdf52b2b1a4505
WebCore:

2008-07-02  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin.

        Fix for <rdar://problem/6015523> Implement ARIA ranges/sliders
        and
        <rdar://problem/5934355> Need to implement ARIA role="spinbutton"

        * page/AccessibilityObject.h:
        (WebCore::AccessibilityObject::isSlider):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isSlider):
        (WebCore::AccessibilityRenderObject::valueForRange):
        (WebCore::AccessibilityRenderObject::maxValueForRange):
        (WebCore::AccessibilityRenderObject::minValueForRange):
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): We
        were addressing the generic has-an-ARIA-role case too early here.
        (WebCore::AccessibilityRenderObject::focusedUIElement): This is a
        bug I ran into while testing role='spinbutton', spinbutton is a
        role that can have an active descendant. But we were always trying
        to forward focus to the active descendant, even if one was not
        specified.
        (WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
        'spinbutton' maps to ProgressIndicatorRole.
        (WebCore::RoleEntry::):
        (WebCore::AccessibilityRenderObject::canSetValueAttribute):
        * page/AccessibilityRenderObject.h:
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

2008-07-02  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin.

        Tests for <rdar://problem/6015523> Implement ARIA ranges/sliders
        and
        <rdar://problem/5934355> Need to implement ARIA role="spinbutton"

        * accessibility/aria-range-expected.txt: Added.
        * accessibility/aria-range.html: Added.
        * accessibility/aria-slider-expected.txt: Added.
        * accessibility/aria-slider.html: Added.
        * accessibility/aria-spinbutton-expected.txt: Added.
        * accessibility/aria-spinbutton.html: Added.

        This test used to have a section for slider. It was a mistake for
        that to be checked in since slider was not implemented until not.
        * accessibility/aria-roles-expected.txt:
        * accessibility/aria-roles.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
14 files changed:
LayoutTests/ChangeLog
LayoutTests/accessibility/aria-range-expected.txt [new file with mode: 0644]
LayoutTests/accessibility/aria-range.html [new file with mode: 0644]
LayoutTests/accessibility/aria-roles-expected.txt
LayoutTests/accessibility/aria-roles.html
LayoutTests/accessibility/aria-slider-expected.txt [new file with mode: 0644]
LayoutTests/accessibility/aria-slider.html [new file with mode: 0644]
LayoutTests/accessibility/aria-spinbutton-expected.txt [new file with mode: 0644]
LayoutTests/accessibility/aria-spinbutton.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/page/AccessibilityObject.h
WebCore/page/AccessibilityRenderObject.cpp
WebCore/page/AccessibilityRenderObject.h
WebCore/page/mac/AccessibilityObjectWrapper.mm