2011-01-14 Abhishek Arya <inferno@chromium.org>
authorinferno@chromium.org <inferno@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 14 Jan 2011 22:40:17 +0000 (22:40 +0000)
committerinferno@chromium.org <inferno@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 14 Jan 2011 22:40:17 +0000 (22:40 +0000)
commit8d1400f4f1dd4c3d8e555661e787ee853695c9fe
treea2ea527d6b45dfb49b00751033b32974bfcf61ae
parentb2ffea64f9b84b3c46987896d682d63b6d8fe377
2011-01-14  Abhishek Arya  <inferno@chromium.org>

        Reviewed by David Hyatt.

        Fix parent block calculation when trying to find top most node
        containing "this" float.
        https://bugs.webkit.org/show_bug.cgi?id=51711

        Replace use of containingBlock and traverse the parents directly
        to check for float existence. containingBlock can skip parents and
        jump to the RenderView directly which will cause floats to not get
        cleared from intermediate parents.

        Test: fast/block/float/floats-not-cleared-crash.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
2011-01-14  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that we do not crash due to uncleared floats in parent nodes.
        https://bugs.webkit.org/show_bug.cgi?id=51711

        * fast/block/float/floats-not-cleared-crash-expected.txt: Added.
        * fast/block/float/floats-not-cleared-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/block/float/floats-not-cleared-crash-expected.txt [new file with mode: 0644]
LayoutTests/fast/block/float/floats-not-cleared-crash.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBox.cpp