change RenderFlexibleBox to act on logical coordinates
authorojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 20 Sep 2011 22:46:19 +0000 (22:46 +0000)
committerojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 20 Sep 2011 22:46:19 +0000 (22:46 +0000)
commit8b0210c28a136b293a01f3f7f9794cd52f691d82
tree68ce09e7ffe9499b488fe734d617bfb0c4179de0
parent506d1920b48d2984c79bbfdcf310b5c786dfa53d
change RenderFlexibleBox to act on logical coordinates
https://bugs.webkit.org/show_bug.cgi?id=68129

Reviewed by David Hyatt.

Source/WebCore:

This makes RenderFlexibleBox respect direction and writing-mode.
We now properly support the default flex-flow value of "row".

Test: css3/flexbox/writing-modes.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::setLogicalLocationForChild):
* rendering/RenderBlock.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::logicalBorderWidthForChild):
(WebCore::RenderFlexibleBox::logicalPaddingWidthForChild):
(WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
(WebCore::RenderFlexibleBox::marginStartStyleForChild):
(WebCore::RenderFlexibleBox::marginEndStyleForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::logicalPositiveFlexForChild):
(WebCore::RenderFlexibleBox::logicalNegativeFlexForChild):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::setLogicalOverrideSize):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
* rendering/RenderFlexibleBox.h:

LayoutTests:

* css3/flexbox/resources/flexbox.js:
* css3/flexbox/writing-modes-expected.txt: Added.
* css3/flexbox/writing-modes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/css3/flexbox/resources/flexbox.js
LayoutTests/css3/flexbox/writing-modes-expected.txt [new file with mode: 0644]
LayoutTests/css3/flexbox/writing-modes.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBlock.cpp
Source/WebCore/rendering/RenderBlock.h
Source/WebCore/rendering/RenderFlexibleBox.cpp
Source/WebCore/rendering/RenderFlexibleBox.h