Remove RELEASE_ASSERT added in r230875.
authorbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Jun 2018 23:56:01 +0000 (23:56 +0000)
committerbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Jun 2018 23:56:01 +0000 (23:56 +0000)
commit8af3d153d9ab01470bcabb53a1fcb754e3d09b02
tree4d6442e8b4370baf796db319655ce856e6a443e4
parent0ef9f951a38c1891a033e7675f30ae96355cad07
Remove RELEASE_ASSERT added in r230875.
<rdar://problem/40860061> and https://bugs.webkit.org/show_bug.cgi?id=187022

Reviewed by Brent Fulgham.

There's actually more than one way for a network session to be destroyed, and that can happen
asynchronously and unpredictably.

And the request to start up a WebSocket and do its handshake is also asynchronous and unpredictable

It's an expected race.

If the NetworkStorageSession cannot be found then the WebSocket handshake should just fail.

* platform/network/SocketStreamHandleImpl.cpp:
(WebCore::cookieDataForHandshake): If the NetworkStorageSession cannot be found, return std::nullopt.
(WebCore::SocketStreamHandleImpl::platformSendHandshake): If the cookieData is null, fail the handshake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/platform/network/SocketStreamHandleImpl.cpp