Have fixedPositionCreatesStackingContext be on by default everywhere
authorsimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 8 Mar 2017 05:46:52 +0000 (05:46 +0000)
committersimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 8 Mar 2017 05:46:52 +0000 (05:46 +0000)
commit8ad5aff6c8d3d678561e265e86d77c618b5f86f0
tree9223d2a6aae4a4e1a0fabd3940821dc6fdd42976
parent6a32fc3de896570b189ee59172721ea1f5a583f8
Have fixedPositionCreatesStackingContext be on by default everywhere
https://bugs.webkit.org/show_bug.cgi?id=169334

Reviewed by Zalan Bujtas.

It makes no sense to have web-exposed CSS functionality be different based on setting,
and other browser are now aligned with having position:fixed create stacking context.

So remove the fixedPositionCreatesStackingContext setting and have StyleResolver::adjustRenderStyle()
always force stacking context for position:fixed.

Source/WebCore:

* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
* page/Settings.cpp:
* page/Settings.in:

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUseFixedLayout):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updatePreferences):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

LayoutTests:

* compositing/absolute-inside-out-of-view-fixed.html:
* compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html:
* compositing/layer-creation/fixed-overlap-extent-rtl.html:
* compositing/layer-creation/fixed-overlap-extent.html:
* compositing/layer-creation/fixed-position-change-out-of-view-in-view.html:
* compositing/layer-creation/fixed-position-in-view-dynamic.html:
* compositing/layer-creation/fixed-position-out-of-view-dynamic.html:
* compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html:
* compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html:
* compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html:
* compositing/layer-creation/fixed-position-out-of-view-scaled.html:
* compositing/layer-creation/fixed-position-transformed-into-view.html:
* compositing/layer-creation/fixed-position-transformed-outside-view.html:
* compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html:
* compositing/repaint/scroll-fixed-layer-no-content.html:
* compositing/repaint/scroll-fixed-layer-out-of-view.html:
* fast/block/positioning/fixed-position-stacking-context2.html:
* fullscreen/full-screen-fixed-pos-parent.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
30 files changed:
LayoutTests/ChangeLog
LayoutTests/compositing/absolute-inside-out-of-view-fixed.html
LayoutTests/compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html
LayoutTests/compositing/layer-creation/fixed-overlap-extent-rtl.html
LayoutTests/compositing/layer-creation/fixed-overlap-extent.html
LayoutTests/compositing/layer-creation/fixed-position-change-out-of-view-in-view.html
LayoutTests/compositing/layer-creation/fixed-position-in-view-dynamic.html
LayoutTests/compositing/layer-creation/fixed-position-out-of-view-dynamic.html
LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html
LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html
LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html
LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled.html
LayoutTests/compositing/layer-creation/fixed-position-transformed-into-view.html
LayoutTests/compositing/layer-creation/fixed-position-transformed-outside-view.html
LayoutTests/compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html
LayoutTests/compositing/repaint/scroll-fixed-layer-no-content.html
LayoutTests/compositing/repaint/scroll-fixed-layer-out-of-view.html
LayoutTests/fast/block/positioning/fixed-position-stacking-context2.html
LayoutTests/fullscreen/full-screen-fixed-pos-parent.html
Source/WebCore/ChangeLog
Source/WebCore/css/StyleResolver.cpp
Source/WebCore/page/Settings.cpp
Source/WebCore/page/Settings.in
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebView/WebView.mm
Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm
Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm