String::createCFString should return a RetainPtr
authorandersca@apple.com <andersca@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 30 Oct 2012 16:10:14 +0000 (16:10 +0000)
committerandersca@apple.com <andersca@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 30 Oct 2012 16:10:14 +0000 (16:10 +0000)
commit8a5746aa275a7889a1647bfe197cf0beb30f3760
tree98edb35bde3db29969781e35326990627b9f459c
parent42080b54e6e4148cd4e37e07b78860e58407a6f8
String::createCFString should return a RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=100419

Reviewed by Andreas Kling.

Source/WebCore:

Update callers of String::createCFString.

* bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject):
* html/HTMLMediaElement.cpp:
(WebCore::createFileURLForApplicationCacheResource):
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createPropertyListRepresentation):
* platform/LocalizedStrings.cpp:
(WebCore::formatLocalizedString):
(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::keygenKeychainItemName):
(WebCore::imageTitle):
* platform/RuntimeApplicationChecks.cpp:
(WebCore::mainBundleIsEqualTo):
* platform/cf/FileSystemCF.cpp:
(WebCore::fileSystemRepresentation):
(WebCore::pathAsURL):
* platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(PlatformCAAnimation::PlatformCAAnimation):
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(resubmitAllAnimations):
(PlatformCALayer::addAnimationForKey):
(PlatformCALayer::removeAnimationForKey):
(PlatformCALayer::setName):
* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::updateTiles):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::utiFromMIMEType):
* platform/graphics/cg/ImageSourceCGMac.mm:
(WebCore::MIMETypeForImageSourceType):
(WebCore::preferredExtensionForImageSourceType):
* platform/mac/ClipboardMac.mm:
(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::utiTypeFromCocoaType):
* platform/mac/SSLKeyGeneratorMac.cpp:
(WebCore::signedPublicKeyAndChallengeString):
* platform/network/cf/AuthenticationCF.cpp:
(WebCore::createCF):
* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::setCookies):
* platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::platformResolve):
* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::cfError):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::setDefaultMIMEType):
(WebCore::willSendRequest):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::setPrivateBrowsingEnabled):
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::setHeaderFields):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::cfURLResponse):
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::createStreams):
(WebCore::SocketStreamHandle::addCONNECTCredentials):
(WebCore::SocketStreamHandle::copyCFStreamDescription):
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
* platform/network/mac/WebCoreURLResponse.mm:
(WebCore::adjustMIMETypeIfNecessary):
* platform/text/cf/HyphenationCF.cpp:
(WebCore::::createValueForKey):
* platform/text/cf/StringCF.cpp:
(WTF::String::createCFString):
* platform/text/cf/StringImplCF.cpp:
(WTF::StringImpl::createCFString):
* platform/text/mac/StringImplMac.mm:
(WTF::StringImpl::operator NSString *):
* platform/text/mac/TextCodecMac.cpp:
(WebCore::TextCodecMac::encode):
* platform/win/SearchPopupMenuWin.cpp:
(WebCore::autosaveKey):
(WebCore::SearchPopupMenuWin::saveRecentSearches):

Source/WebKit/cf:

Update callers of String::createCFString.

* WebCoreSupport/WebInspectorClientCF.cpp:
(createKeyForPreferences):
(populateSetting):
(storeSetting):

Source/WebKit/win:

Update callers of String::createCFString.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
* WebDatabaseManager.cpp:
(WebDatabaseManager::dispatchDidModifyDatabase):
* WebHistory.cpp:
(WebHistory::visitedURL):
(WebHistory::itemForURLString):
* WebHistoryItem.cpp:
(WebHistoryItem::dictionaryRepresentation):
* WebIconDatabase.cpp:
(WebIconDatabase::iconDatabaseNotificationUserInfoURLKey):
(postDidAddIconNotification):
* WebLocalizableStrings.cpp:
(createWebKitBundle):
(copyLocalizedStringFromBundle):
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
* WebView.cpp:
(WebView::setCacheModel):
(WebView::notifyPreferencesChanged):

Source/WebKit2:

Update callers of String::createCFString.

* Platform/mac/ModuleMac.mm:
(WebKit::Module::load):
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::initializeSandbox):
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::getPluginInfo):
(WebKit::NetscapePluginModule::createPluginMIMETypesPreferences):
* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::sessionStateData):
(WebKit::autosaveKey):
(WebKit::WebPageProxy::saveRecentSearches):
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::cachedResponseForURL):
* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

Make String::createCFString and StringImpl::createCFString return RetainPtrs.

* wtf/text/AtomicString.h:
* wtf/text/StringImpl.h:
* wtf/text/WTFString.h:

Tools:

Update callers of String::createCFString.

* WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
(WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
55 files changed:
Source/WTF/ChangeLog
Source/WTF/wtf/text/StringImpl.h
Source/WTF/wtf/text/WTFString.h
Source/WebCore/ChangeLog
Source/WebCore/bridge/objc/objc_runtime.mm
Source/WebCore/html/HTMLMediaElement.cpp
Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp
Source/WebCore/platform/LocalizedStrings.cpp
Source/WebCore/platform/RuntimeApplicationChecks.cpp
Source/WebCore/platform/cf/FileSystemCF.cpp
Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp
Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp
Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp
Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp
Source/WebCore/platform/graphics/cg/ImageSourceCGMac.mm
Source/WebCore/platform/mac/ClipboardMac.mm
Source/WebCore/platform/mac/SSLKeyGeneratorMac.cpp
Source/WebCore/platform/network/cf/AuthenticationCF.cpp
Source/WebCore/platform/network/cf/CookieJarCFNet.cpp
Source/WebCore/platform/network/cf/DNSCFNet.cpp
Source/WebCore/platform/network/cf/ResourceErrorCF.cpp
Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp
Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp
Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp
Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp
Source/WebCore/platform/network/mac/ResourceRequestMac.mm
Source/WebCore/platform/network/mac/WebCoreURLResponse.mm
Source/WebCore/platform/text/cf/HyphenationCF.cpp
Source/WebCore/platform/text/cf/StringCF.cpp
Source/WebCore/platform/text/cf/StringImplCF.cpp
Source/WebCore/platform/text/mac/StringImplMac.mm
Source/WebCore/platform/text/mac/TextCodecMac.cpp
Source/WebCore/platform/win/SearchPopupMenuWin.cpp
Source/WebKit/cf/ChangeLog
Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp
Source/WebKit/win/ChangeLog
Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp
Source/WebKit/win/WebDatabaseManager.cpp
Source/WebKit/win/WebHistory.cpp
Source/WebKit/win/WebHistoryItem.cpp
Source/WebKit/win/WebIconDatabase.cpp
Source/WebKit/win/WebLocalizableStrings.cpp
Source/WebKit/win/WebPreferences.cpp
Source/WebKit/win/WebView.cpp
Source/WebKit2/ChangeLog
Source/WebKit2/Platform/mac/ModuleMac.mm
Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm
Source/WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm
Source/WebKit2/UIProcess/cf/WebBackForwardListCF.cpp
Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp
Source/WebKit2/WebProcess/ResourceCache/WebResourceCacheManager.cpp
Source/WebKit2/WebProcess/WebPage/win/WebPageWin.cpp
Source/WebKit2/WebProcess/win/WebProcessWin.cpp
Tools/ChangeLog
Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm