Text-shadow with (0, 0) offset and radius = 0 is ugly
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Aug 2014 17:35:59 +0000 (17:35 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Aug 2014 17:35:59 +0000 (17:35 +0000)
commit870de3d9f0836f0fe31d876381b2c875aee0d46e
tree0d32bdd592185ccbe6055e840739132164d04c24
parent7ac137e1b723a83f3ed50c41d4aa71e1ae6907c9
Text-shadow with (0, 0) offset and radius = 0 is ugly
https://bugs.webkit.org/show_bug.cgi?id=135357

Reviewed by Darin Adler.

Source/WebCore:

Instead, check for this kind of shadow and don't draw it.

Test: fast/text/empty-shadow.html

* rendering/TextPainter.cpp:
(WebCore::isEmptyShadow): Does a shadow match these criteria?
(WebCore::paintTextWithShadows): If so, don't draw it.

LayoutTests:

Check that this kind of shadow ends up invisible.

* fast/text/empty-shadow-expected.html: Added
* fast/text/empty-shadow.html: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/text/empty-shadow-expected.html [new file with mode: 0644]
LayoutTests/fast/text/empty-shadow.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/TextPainter.cpp