2011-04-26 Dinesh K Garg <dineshg@codeaurora.org>
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Apr 2011 01:28:10 +0000 (01:28 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Apr 2011 01:28:10 +0000 (01:28 +0000)
commit83a939032e83a0d8e45023ff8400acf8f6efceda
tree8e8368971c8c00bc63e75069d30919a3dec58802
parentf01e57e7dfce10e2a40872772c1d49bbd573e013
2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>

        Reviewed by Eric Seidel.

        Test case for: beginElement broken by setAttribute
        https://bugs.webkit.org/show_bug.cgi?id=26019

        * svg/animations/animate-beginElementAt-expected.txt: Added.
        * svg/animations/animate-beginElementAt.svg: Added.
        * svg/animations/animate-dynamic-update-attributeName-expected.txt:
        Nice side effect of the patch, we are now fully passing this test.
2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>

        Reviewed by Eric Seidel.

        beginElement broken by setAttribute
        https://bugs.webkit.org/show_bug.cgi?id=26019

        Test: svg/animations/animate-beginElementAt.svg

        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::attributeChanged):
        Reset the animation state here as the rest of the code reads it and would still
        think we are animating when we are not.

        * svg/animation/SVGSMILElement.h:
        (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/svg/animations/animate-beginElementAt-expected.txt [new file with mode: 0644]
LayoutTests/svg/animations/animate-beginElementAt.svg [new file with mode: 0755]
LayoutTests/svg/animations/animate-dynamic-update-attributeName-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/svg/SVGAnimationElement.cpp
Source/WebCore/svg/animation/SVGSMILElement.h