REGRESSION: -webkit-appearance test case crashes
authorzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Jan 2019 02:34:19 +0000 (02:34 +0000)
committerzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Jan 2019 02:34:19 +0000 (02:34 +0000)
commit80f01663e12fc11256b61d89e61293ab7d5f399a
treec75caa2f543d7f98dc044c7a67c41d7c59e8234d
parent0c73379b500fda6d474274cb4316e9de8fea49b2
REGRESSION: -webkit-appearance test case crashes
https://bugs.webkit.org/show_bug.cgi?id=189302
<rdar://problem/44143049>

Reviewed by Wenson Hsieh.

Source/WebCore:

The painting and the layout positions of the cancel button need to match in order to be able to interact with it.
This patch removes the previous position inlining attempts.

Test: fast/forms/webkit-appearance-searchfield-cancel-button-crash.html

* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):

LayoutTests:

* fast/forms/webkit-appearance-searchfield-cancel-button-crash-expected.txt: Added.
* fast/forms/webkit-appearance-searchfield-cancel-button-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/forms/webkit-appearance-searchfield-cancel-button-crash-expected.txt [new file with mode: 0644]
LayoutTests/fast/forms/webkit-appearance-searchfield-cancel-button-crash.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderThemeMac.mm