[WebIDL] Simplify XMLHttpRequest bindings by removing built-ins
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 22 Jul 2017 03:54:16 +0000 (03:54 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 22 Jul 2017 03:54:16 +0000 (03:54 +0000)
commit80c3381e8d65e017c18eafd48caace50b71409c4
treeb23256daf8f8e30fdf4e5049b96edfd77d808ec3
parent6d1f8d31e609f492b2c45d6b913e98ce32ec2219
[WebIDL] Simplify XMLHttpRequest bindings by removing built-ins
https://bugs.webkit.org/show_bug.cgi?id=174740

Patch by Sam Weinig <sam@webkit.org> on 2017-07-21
Reviewed by Chris Dumez.

The behavior we were getting from XMLHttpRequest.js can be implemented
with the [CachedAttribute] extended attribute. This reduces the number
of JS -> C++ jumps required and makes the code more similar to other
bindings that need caching of an IDL any value.

* CMakeLists.txt:
* DerivedSources.make:
* xml/XMLHttpRequest.js: Removed.
Remove XMLHttpRequest.js.

* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::response):
(WebCore::JSXMLHttpRequest::retrieveResponse): Deleted.
* xml/XMLHttpRequest.idl:
Replace builtin with a [CachedAttribute] and [CustomGetter]
for the response property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@219757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/CMakeLists.txt
Source/WebCore/ChangeLog
Source/WebCore/DerivedSources.make
Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp
Source/WebCore/xml/XMLHttpRequest.idl
Source/WebCore/xml/XMLHttpRequest.js [deleted file]