2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>
authormario@webkit.org <mario@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 11 Apr 2011 17:39:11 +0000 (17:39 +0000)
committermario@webkit.org <mario@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 11 Apr 2011 17:39:11 +0000 (17:39 +0000)
commit7ff07cb3f8e3f0126c137cb36c77cfd80ba54dee
treeeb66094bf3d111a7792c73c72a4dd757e422c122
parentd233eefc0760c4a498672f3a4035067ccd473e50
2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] ARIA tables not exposing cells as HTML tables do
        https://bugs.webkit.org/show_bug.cgi?id=57463

        Unskipped passing test and added GTK-specific expectations.

        * platform/gtk/Skipped: Unskip accessibility test.
        * platform/gtk/accessibility/aria-table-hierarchy-expected.txt: Added.
2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] ARIA tables not exposing cells as HTML tables do
        https://bugs.webkit.org/show_bug.cgi?id=57463

        Expose cells for ARIA grids consistently with HTML tables in GTK,
        keeping the same behaviour for the other platforms.

        * accessibility/AccessibilityARIAGrid.cpp:
        (WebCore::AccessibilityARIAGrid::addChild): Add the row's children
        to the accessibility hierarchy when accessibility objects for rows
        are ignoring accessibility, otherwise add the row.
        (WebCore::AccessibilityARIAGrid::addChildren): Do not check at
        this point whether every child of the table ignores or not
        accessibility, letting addChild() make the proper decision later.

        * accessibility/AccessibilityARIAGridCell.cpp:
        (WebCore::AccessibilityARIAGridCell::parentTable): Consider that
        rows could be ignoring accessibility, hence the parent could be
        retrieved in the first call to parentObjectUnignored().
        (WebCore::AccessibilityARIAGridCell::rowIndexRange): Ditto.
        (WebCore::AccessibilityARIAGridCell::columnIndexRange): Ditto..

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (atkRole): Map ColumnHeader and RowHeader to ATK_ROLE_TABLE_CELL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/platform/gtk/Skipped
LayoutTests/platform/gtk/accessibility/aria-table-hierarchy-expected.txt [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/accessibility/AccessibilityARIAGrid.cpp
Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp
Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp