2011-04-04 Chang Shu <cshu@webkit.org>
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Apr 2011 22:49:22 +0000 (22:49 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Apr 2011 22:49:22 +0000 (22:49 +0000)
commit7e1186a5eb9dfb381320e5b272f36b9c5e1f2390
tree9681654aad0cac282ddf245ba3be7f4879d95092
parent8e0ee1978874802efff8b7a465f6883effb465c0
2011-04-04  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        setContentEditable with true/false/inherit string is not working properly
        https://bugs.webkit.org/show_bug.cgi?id=52058

        Updated expected results after this patch fixes the set contenteditable issue.

        * fast/dom/HTMLElement/set-false-expected.txt:
        * fast/dom/HTMLElement/set-false.html:
        * fast/dom/HTMLElement/set-inherit-parent-false-expected.txt:
        * fast/dom/HTMLElement/set-inherit-parent-true-expected.txt:
        * fast/dom/HTMLElement/set-true-expected.txt:
        * fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:
2011-04-04  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        setContentEditable with true/false/inherit string is not working properly
        https://bugs.webkit.org/show_bug.cgi?id=52058

        Move isContentEditable from HTMLElement to Node. Thus, Node provides two functions for
        checking editability: rendererIsEditable and isContentEdiable. The former is a fast path,
        which does NOT trigger layout and only checks the render style of usermodify. The latter
        updates the layout first to make sure the render style syncs with DOM contenteditable
        attribute. Certain call sites that need to call isContentEditable rather than rendererIsEditable
        are also updated in the patch. But a complete fix will follow up in bug 57244.

        This patch fixes all the failed layout tests related to set contenteditable.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isReadOnly):
        * dom/Node.cpp:
        (WebCore::Node::isContentEditable):
        (WebCore::Node::shouldUseInputMethod):
        * dom/Node.h:
        * html/HTMLElement.cpp:
        * html/HTMLElement.h:
2011-04-04  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        setContentEditable with true/false/inherit string is not working properly
        https://bugs.webkit.org/show_bug.cgi?id=52058

        Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
        as rendererIsEditable is for WebCore internal use.

        * src/WebNode.cpp:
        (WebKit::WebNode::isContentEditable):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setFocus):
        (WebKit::WebViewImpl::setComposition):
        (WebKit::WebViewImpl::confirmComposition):
2011-04-04  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        setContentEditable with true/false/inherit string is not working properly
        https://bugs.webkit.org/show_bug.cgi?id=52058

        Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
        as rendererIsEditable is for WebCore internal use.

        * WebCoreSupport/EditorClientHaiku.cpp:
        (WebCore::EditorClientHaiku::handleKeyboardEvent):
2011-04-04  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        setContentEditable with true/false/inherit string is not working properly
        https://bugs.webkit.org/show_bug.cgi?id=52058

        Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
        as rendererIsEditable is for WebCore internal use.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
20 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/dom/HTMLElement/set-false-expected.txt
LayoutTests/fast/dom/HTMLElement/set-false.html
LayoutTests/fast/dom/HTMLElement/set-inherit-parent-false-expected.txt
LayoutTests/fast/dom/HTMLElement/set-inherit-parent-true-expected.txt
LayoutTests/fast/dom/HTMLElement/set-true-expected.txt
LayoutTests/fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/accessibility/AccessibilityRenderObject.cpp
Source/WebCore/dom/Node.cpp
Source/WebCore/dom/Node.h
Source/WebCore/html/HTMLElement.cpp
Source/WebCore/html/HTMLElement.h
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/WebNode.cpp
Source/WebKit/chromium/src/WebViewImpl.cpp
Source/WebKit/haiku/ChangeLog
Source/WebKit/haiku/WebCoreSupport/EditorClientHaiku.cpp
Source/WebKit/qt/ChangeLog
Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp