Don't consider container nodes of other disambiguated nodes
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 14 Dec 2012 01:09:58 +0000 (01:09 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 14 Dec 2012 01:09:58 +0000 (01:09 +0000)
commit7cd254add8734157412b7dc68e80e3dc0c6c34d9
treeb44007e39d6c4d7f34826c93e61a7ab368958789
parenta0842e7e6a0a346fb898860b823505cce8ef02fb
Don't consider container nodes of other disambiguated nodes
https://bugs.webkit.org/show_bug.cgi?id=104619

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-12-13
Reviewed by Eric Seidel.

Source/WebCore:

It is not uncommon to have a clickable <div> that contains other clickable objects.
This heuristic avoids excessive disambiguation in that case.

New unit test: WebFrameTest.DisambiguationPopupNoContainer

* page/TouchDisambiguation.cpp:
(WebCore::findGoodTouchTargets):

Source/WebKit/chromium:

Added a test to track the new disambiguation popup heuristics.

* tests/WebFrameTest.cpp:
* tests/data/disambiguation_popup_no_container.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@137686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/page/TouchDisambiguation.cpp
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/tests/WebFrameTest.cpp
Source/WebKit/chromium/tests/data/disambiguation_popup_no_container.html [new file with mode: 0644]