Activate -Wexit-time-destructors -and Wglobal-constructors in libwebrtc
authoryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Jun 2018 23:21:06 +0000 (23:21 +0000)
committeryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Jun 2018 23:21:06 +0000 (23:21 +0000)
commit7c4a21a9eebc3e351e2016b6f6e57967caafb308
tree73bf98b696842f3dc6d3f2629851c2c000e69b9e
parent2612ced981a6ea309fe867dd587b051185576478
Activate -Wexit-time-destructors -and Wglobal-constructors in libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=186615

Reviewed by Darin Adler.

Update xcconfig files to activate these compile flags.
Also enable -Wthread-safety since libwebrtc code is using some related attributes.
Update libwebrtc code base to accomodate these flags.

* Configurations/libwebrtc.xcconfig:
* Configurations/opus.xcconfig:
* Configurations/usrsctp.xcconfig:
* Source/webrtc/modules/audio_processing/beamformer/array_util.h:
(webrtc::DegreesToRadians): Make function constexpr.
* Source/webrtc/modules/rtp_rtcp/source/rtp_utility.cc:
Make sure the destructor is never called.
* Source/webrtc/rtc_base/logging.cc:
Update code to move streams_ from a static class member to a regular static function variable.
* Source/webrtc/rtc_base/logging.h:
* Source/webrtc/system_wrappers/source/clock.cc:
Make sure the destructor is never called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@232858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/ThirdParty/libwebrtc/ChangeLog
Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig
Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig
Source/ThirdParty/libwebrtc/Configurations/usrsctp.xcconfig
Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/beamformer/array_util.h
Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_utility.cc
Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc
Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.h
Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/virtualsocketserver.cc
Source/ThirdParty/libwebrtc/Source/webrtc/system_wrappers/source/clock.cc