ASSERT(renderer()) under HTMLTextAreaElement::updateValue()
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Nov 2018 03:11:33 +0000 (03:11 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Nov 2018 03:11:33 +0000 (03:11 +0000)
commit7a603f07e5b50a44402aeed2a8b83c3e1ce18623
tree0d7715cddbe8bf4e8b4de359ed36bcfc0996178a
parent9d7cc906c6dd909747d0f1e305d69168d2c5f310
ASSERT(renderer()) under HTMLTextAreaElement::updateValue()
https://bugs.webkit.org/show_bug.cgi?id=191391
<rdar://problem/34219633>

Reviewed by Geoffrey Garen.

Source/WebCore:

Update HTMLTextFormControlElement::didEditInnerTextValue() to not call subtreeHasChanged()
if the element has no renderer, similarly to what is already done in
HTMLTextFormControlElement::setRangeText() and HTMLInputElement::setEditingValue().

Test: editing/inserting/inset-html-textarea-without-renderer.html

* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::didEditInnerTextValue):

LayoutTests:

Add layout test coverage. I have verified that this test passes in Firefox and Chrome.
It used to crash before this change in debug.

* editing/inserting/inset-html-textarea-without-renderer-expected.txt: Added.
* editing/inserting/inset-html-textarea-without-renderer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/editing/inserting/inset-html-textarea-without-renderer-expected.txt [new file with mode: 0644]
LayoutTests/editing/inserting/inset-html-textarea-without-renderer.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/html/HTMLTextFormControlElement.cpp