[css-grid] Swap columns and rows in grid-template shorthand
authorrego@igalia.com <rego@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 22 Feb 2016 14:08:41 +0000 (14:08 +0000)
committerrego@igalia.com <rego@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 22 Feb 2016 14:08:41 +0000 (14:08 +0000)
commit79aee0afb4998e82d61edc40c858ac25b7e7ab97
treedb16f93a7408aa110408ef3523e7292d962242d1
parenteb9318a9ac6034bcb997a3c3d939493c0975e465
[css-grid] Swap columns and rows in grid-template shorthand
https://bugs.webkit.org/show_bug.cgi?id=154472

Reviewed by Darin Adler.

The spec was modified past December to change the order of
columns and rows in the grid-template shorthand:
https://github.com/w3c/csswg-drafts/commit/f6c7691679a519017a80ebae44fd86c3eae5c5f9

Updated the parsing and modified the tests to follow the new syntax.

Source/WebCore:

* css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTemplateColumns):
(WebCore::CSSParser::parseGridTemplateRowsAndAreasAndColumns):
(WebCore::CSSParser::parseGridTemplateShorthand):
(WebCore::CSSParser::parseGridTemplateRowsAndAreas): Renamed to
parseGridTemplateRowsAndAreasAndColumns().
* css/CSSParser.h:

LayoutTests:

* fast/css-grid-layout/absolute-positioning-definite-sizes.html:
* fast/css-grid-layout/flex-content-distribution.html:
* fast/css-grid-layout/grid-align-content-vertical-lr.html:
* fast/css-grid-layout/grid-align-content-vertical-rl.html:
* fast/css-grid-layout/grid-align-content.html:
* fast/css-grid-layout/grid-gutters-and-alignment.html:
* fast/css-grid-layout/grid-gutters-and-flex-content.html:
* fast/css-grid-layout/grid-gutters-and-tracks.html:
* fast/css-grid-layout/grid-justify-content-vertical-lr.html:
* fast/css-grid-layout/grid-justify-content-vertical-rl.html:
* fast/css-grid-layout/grid-justify-content.html:
* fast/css-grid-layout/grid-shorthand-get-set.html:
* fast/css-grid-layout/grid-template-shorthand-get-set.html:
* fast/css-grid-layout/relayout-align-items-changed.html:
* fast/css-grid-layout/relayout-align-self-changed.html:
* fast/css-grid-layout/relayout-indefinite-heights.html:
* fast/css-grid-layout/relayout-justify-items-changed.html:
* fast/css-grid-layout/relayout-justify-self-changed.html:
* fast/repaint/align-items-overflow-change.html:
* fast/repaint/align-self-change.html:
* fast/repaint/align-self-overflow-change.html:
* fast/repaint/justify-items-change.html:
* fast/repaint/justify-items-overflow-change.html:
* fast/repaint/justify-self-change.html:
* fast/repaint/justify-self-overflow-change.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
29 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/css-grid-layout/absolute-positioning-definite-sizes.html
LayoutTests/fast/css-grid-layout/flex-content-distribution.html
LayoutTests/fast/css-grid-layout/grid-align-content-vertical-lr.html
LayoutTests/fast/css-grid-layout/grid-align-content-vertical-rl.html
LayoutTests/fast/css-grid-layout/grid-align-content.html
LayoutTests/fast/css-grid-layout/grid-gutters-and-alignment.html
LayoutTests/fast/css-grid-layout/grid-gutters-and-flex-content.html
LayoutTests/fast/css-grid-layout/grid-gutters-and-tracks.html
LayoutTests/fast/css-grid-layout/grid-justify-content-vertical-lr.html
LayoutTests/fast/css-grid-layout/grid-justify-content-vertical-rl.html
LayoutTests/fast/css-grid-layout/grid-justify-content.html
LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html
LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html
LayoutTests/fast/css-grid-layout/relayout-align-items-changed.html
LayoutTests/fast/css-grid-layout/relayout-align-self-changed.html
LayoutTests/fast/css-grid-layout/relayout-indefinite-heights.html
LayoutTests/fast/css-grid-layout/relayout-justify-items-changed.html
LayoutTests/fast/css-grid-layout/relayout-justify-self-changed.html
LayoutTests/fast/repaint/align-items-overflow-change.html
LayoutTests/fast/repaint/align-self-change.html
LayoutTests/fast/repaint/align-self-overflow-change.html
LayoutTests/fast/repaint/justify-items-change.html
LayoutTests/fast/repaint/justify-items-overflow-change.html
LayoutTests/fast/repaint/justify-self-change.html
LayoutTests/fast/repaint/justify-self-overflow-change.html
Source/WebCore/ChangeLog
Source/WebCore/css/CSSParser.cpp
Source/WebCore/css/CSSParser.h