REGRESSION (r220052): [Sierra] API test VideoControlsManager.VideoControlsManagerFull...
authordarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Sep 2017 16:27:38 +0000 (16:27 +0000)
committerdarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Sep 2017 16:27:38 +0000 (16:27 +0000)
commit7928f0bec8a0916365db355fcaedb4d6ac0ee480
treeedb95ff2b90c9456cd39183e62ad4931c80fd317
parentdde26e6cf85f2a7cf0cca565cc62986b66c73e12
REGRESSION (r220052): [Sierra] API test VideoControlsManager.VideoControlsManagerFullSizeVideoInWideMainFrame is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=175329

Reviewed by Wenson Hsieh.

These tests rely on using setTimeout to wait a run loop iteration for the
video controls to appear. With changes to how loading occurs, it can now
take two run loop iterations. The concept here is inherently a bit flaky
and racy -- end users will not be able to tell how many run loop cycles it
takes for controls to come up, and websites can't tell either -- but for now
changing the tests to wait one more run loop should get rid of the flakiness.

* TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm: Re-enable test.

* TestWebKitAPI/Tests/WebKitCocoa/full-size-autoplaying-video-with-audio.html: Add a
second setTimeout and a comment.
* TestWebKitAPI/Tests/WebKitCocoa/skinny-autoplaying-video-with-audio.html: Ditto.
* TestWebKitAPI/Tests/WebKitCocoa/wide-autoplaying-video-with-audio.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Tools/ChangeLog
Tools/TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm
Tools/TestWebKitAPI/Tests/WebKitCocoa/full-size-autoplaying-video-with-audio.html
Tools/TestWebKitAPI/Tests/WebKitCocoa/skinny-autoplaying-video-with-audio.html
Tools/TestWebKitAPI/Tests/WebKitCocoa/wide-autoplaying-video-with-audio.html