WebCore: [chromium] REGRESSION(72141): Chromium fails acid3 on windows and linux
authorsfalken@apple.com <sfalken@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 18 Nov 2010 20:42:44 +0000 (20:42 +0000)
committersfalken@apple.com <sfalken@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 18 Nov 2010 20:42:44 +0000 (20:42 +0000)
commit7779874f8c52a65aa2579c1c2762aa992f3163f1
tree800b753a4f58c70d22c5b0fbf2bc91389305a4d2
parent644de7109b90cc57805edb6e538272d93bb4858d
WebCore: [chromium] REGRESSION(72141): Chromium fails acid3 on windows and linux
https://bugs.webkit.org/show_bug.cgi?id=49638

Patch by James Robinson <jamesr@chromium.org> on 2010-11-18
Reviewed by Darin Fisher.

Avoid clamping zero text size to 12pt in FontPlatformData::setupPaint() in FontPlatformDataLinux.cpp
Set all metrics to 0 if the font size is specified as zero in SimpleFontDataChromiumWin.cpp, just
like Safari Win did in r72270.

Test: fast/text/font-size-zero.html

* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::setupPaint):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):

WebKit/win: Debug_Internal Windows configuration is unnecessary, should be removed
https://bugs.webkit.org/show_bug.cgi?id=49753

Reviewed by Adam Roben.

* WebKitPrefix.h:

WebKit2: Keep the web process alive if there are active downloads
https://bugs.webkit.org/show_bug.cgi?id=49755

Patch by Anders Carlsson <andersca@apple.com> on 2010-11-18
Reviewed by Sam Weinig.

Make sure that Download objects are destroyed when the download finishes or fails.
Don't close the web process if there are live Download objects.

* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didFail):
Add stub.

* UIProcess/Downloads/DownloadProxy.h:
* UIProcess/Downloads/DownloadProxy.messages.in:
Add DidFail message.

* WebProcess/Downloads/Download.cpp:
(WebKit::Download::didFinish):
Call DownloadManager::downloadFinished.

(WebKit::Download::didFail):
Send DidFail message and call DownloadManager::downloadFinished.

* WebProcess/Downloads/Download.h:
(WebKit::Download::destinationID):
Call downloadID().

(WebKit::Download::downloadID):
Return the download ID.

* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::downloadFinished):
Delete the Download object and call WebProcess::shutdownIfPossible.

* WebProcess/Downloads/DownloadManager.h:
(WebKit::DownloadManager::isDownloading):
Return whether the download manager has any active downloads.

* WebProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate download:didFailWithError:]):
Call Download::didFail.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::removeWebPage):
Call shutdownIfPossible.

(WebKit::WebProcess::shutdownIfPossible):
New function. Don't shutdown if there are live pages or active downloads.

* WebProcess/WebProcess.h:

WebKitLibraries: Debug_Internal Windows configuration is unnecessary, should be removed
https://bugs.webkit.org/show_bug.cgi?id=49753

Reviewed by Adam Roben.

* win/tools/vsprops/debug.vsprops:
* win/tools/vsprops/debug_internal.vsprops:

WebKitTools: update-webkit-support-libs should fall back to existing
WebKitSupportLibrary version if there is no internet connectivity
https://bugs.webkit.org/show_bug.cgi?id=49503

Patch by Daniel Bates <dbates@rim.com> on 2010-11-18
Reviewed by Adam Roben.

Fall back to existing support libraries (if present) when there is
no internet connection.

Currently, update-webkit-support-libs dies with an "out-of-date"
error when there is no internet connection because it cannot
retrieve versioning information from developer.apple.com. Because
update-webkit-support-libs fails, build-webkit fails. Instead,
if there is no internet connection and the support libraries are
present then we should warn the user and exit() with success so
that build-webkit can work without an internet connection.

* Scripts/update-webkit-support-libs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
15 files changed:
WebCore/ChangeLog
WebCore/WebCorePrefix.h
WebKit/win/ChangeLog
WebKit/win/WebKitPrefix.h
WebKit2/ChangeLog
WebKit2/UIProcess/Launcher/win/ProcessLauncherWin.cpp
WebKit2/WebKit2Prefix.h
WebKitLibraries/ChangeLog
WebKitLibraries/win/tools/vsprops/debug.vsprops
WebKitLibraries/win/tools/vsprops/debug_internal.vsprops
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp
WebKitTools/MiniBrowser/win/stdafx.h
WebKitTools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp
WebKitTools/WebKitTestRunner/win/TestControllerWin.cpp