2010-09-17 Johnny Ding <jnd@chromium.org>
authorinferno@chromium.org <inferno@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 17 Sep 2010 16:36:53 +0000 (16:36 +0000)
committerinferno@chromium.org <inferno@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 17 Sep 2010 16:36:53 +0000 (16:36 +0000)
commit744ff913dcab911d06915dc2814cf0689fcc2455
treee62a51d17f78bb9358e1c0e2363b2dcf1e3e2631
parent30381150d0ebffd962cbc724072e52fcb0cdced6
2010-09-17  Johnny Ding  <jnd@chromium.org>

        Reviewed by Adam Barth.

        Stop history reload navigation to bypass WebKit's popup blocker.
        Now history reload can only navigate the page in self frame, no matter
        what target frame is defined in <base> and no new window can be created.
        https://bugs.webkit.org/show_bug.cgi?id=45369

        Test: fast/events/popup-blocked-from-history-reload.html

        * loader/RedirectScheduler.cpp:
        (WebCore::ScheduledNavigation::ScheduledNavigation):
        (WebCore::ScheduledNavigation::wasUserGesture):
        Move the m_wasUserGesture to base class ScheduledNavigation. Then all
        asynchronous navigation situations can restore the correct gesture state
        during the real navigation process.
        (WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
        (WebCore::ScheduledURLNavigation::fire):
        (WebCore::ScheduledURLNavigation::referrer):
        (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
        (WebCore::ScheduledHistoryNavigation::fire):
        (WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
        (WebCore::ScheduledFormSubmission::fire):
        (WebCore::RedirectScheduler::scheduleHistoryNavigation):
2010-09-17  Johnny Ding  <jnd@chromium.org>

        Reviewed by Adam Barth.

        Stop history reload navigation to bypass WebKit's popup blocker.
        https://bugs.webkit.org/show_bug.cgi?id=45369

        * fast/events/popup-blocked-from-history-reload-expected.txt: Added.
        * fast/events/popup-blocked-from-history-reload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/events/popup-blocked-from-history-reload-expected.txt [new file with mode: 0644]
LayoutTests/fast/events/popup-blocked-from-history-reload.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/loader/RedirectScheduler.cpp