LayoutTests:
authorjusting <justing@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 3 Apr 2006 23:58:43 +0000 (23:58 +0000)
committerjusting <justing@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 3 Apr 2006 23:58:43 +0000 (23:58 +0000)
commit7386d3a5099503ea1edb205a0bef9e9f4828c9c7
tree25e250922c58c84c6889e7418aa790fc2e7b9044
parentfe865be175b19307c36e90b2475a5ea39454ab58
LayoutTests:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8117>
        REGRESSION (NativeTextField): Drag and drop text within a text input field modifies page
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7567>
        A drag and drop in DumpRenderTree copies the source, instead of cutting it

        * editing/pasteboard/drag-drop-modifies-page-expected.checksum: Added.
        * editing/pasteboard/drag-drop-modifies-page-expected.png: Added.
        * editing/pasteboard/drag-drop-modifies-page-expected.txt: Added.
        * editing/pasteboard/drag-drop-modifies-page.html: Added.

        Updated:
        * fast/lists/drag-onto-marker.html:
        * fast/lists/drag-onto-marker-expected.txt:
        * fast/lists/drag-onto-marker-expected.png:
        * fast/lists/drag-onto-marker-expected.checksum:

WebCore:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8117>
        REGRESSION (NativeTextField): Drag and drop text within a text input field modifies page

        The frame's selection is only set after all sub-commands have been
        performed.  When we send the khtmlBeforeTextInsertedEvent to the root
        editable element we were using frame->selection(), which may no longer
        be in the document.

        Had to move the construction of the ReplacementFragment to when the
        replace operation is applied, because endingSelection isn't the
        endingSelection of the last operation when the replace operation
        is constructed.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
        (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.h:

WebKitTools:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7567>
        A drag and drop in DumpRenderTree copies the source, instead of cutting it

        Tell the source that the drag is over after the drag is performed, not before.

        * DumpRenderTree/EventSendingController.m:
        (-[EventSendingController mouseUp]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
14 files changed:
LayoutTests/ChangeLog
LayoutTests/editing/pasteboard/drag-drop-modifies-page-expected.checksum [new file with mode: 0644]
LayoutTests/editing/pasteboard/drag-drop-modifies-page-expected.png [new file with mode: 0644]
LayoutTests/editing/pasteboard/drag-drop-modifies-page-expected.txt [new file with mode: 0644]
LayoutTests/editing/pasteboard/drag-drop-modifies-page.html [new file with mode: 0644]
LayoutTests/fast/lists/drag-into-marker-expected.checksum
LayoutTests/fast/lists/drag-into-marker-expected.png
LayoutTests/fast/lists/drag-into-marker-expected.txt
LayoutTests/fast/lists/drag-into-marker.html
WebCore/ChangeLog
WebCore/editing/ReplaceSelectionCommand.cpp
WebCore/editing/ReplaceSelectionCommand.h
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/EventSendingController.m