CSS 2.1 failure: height-width-table-001.htm
authorrobert@webkit.org <robert@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 15 Oct 2011 11:32:40 +0000 (11:32 +0000)
committerrobert@webkit.org <robert@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 15 Oct 2011 11:32:40 +0000 (11:32 +0000)
commit72bc1314581a659a62215ffb063386f4dfcc24a9
tree04d0ccffb6d4f9453821fc0a770c2b347e882b73
parent33d9c87ad5c32160d01130246501965fec876a08
CSS 2.1 failure: height-width-table-001.htm
https://bugs.webkit.org/show_bug.cgi?id=69709

Reviewed by Simon Fraser.

Source/WebCore:

CSS 2.1 expects CSS table elements to treat fixed height/width as
excluding table borders, but HTML table elements to treat fixed height/width as
including them.

See http://lists.w3.org/Archives/Public/www-style/2011Jan/0178.html
    http://lists.w3.org/Archives/Public/public-css-testsuite/2011Oct/0005.html

It looks like some clarification is pending in the specs, but the new behaviour
lets WebKit pass the following tests in the suite CSS and also match FF:
  height-width-table-001.htm
  height-width-inline-table-001.htm
  abspos-containing-block-initial-004d.htm

* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::layout):

LayoutTests:

* css2.1/20110323/abspos-containing-block-initial-001-ref.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-001.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-004-ref-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-004-ref-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-004-ref.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-004a-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-004a-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-004a.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-004b-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-004b-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-004b.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-004c-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-004c-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-004c.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-004d-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-004d-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-004d.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-004d.htm.1: Added.
* css2.1/20110323/abspos-containing-block-initial-004e-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-004e-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-004e.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-004f-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-004f-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-004f.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-005-ref-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-005-ref-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-005-ref.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-005a-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-005a-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-005a.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-005b-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-005b-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-005b.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-005c-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-005c-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-005c.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-005d-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-005d-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-005d.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-007-ref.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-007.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-009-ref-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-009-ref-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-009-ref.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-009a-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-009a-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-009a.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-009b-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-009b-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-009b.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-009e-expected.png: Added
* css2.1/20110323/abspos-containing-block-initial-009e-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-009e.htm: Added.
* css2.1/20110323/abspos-containing-block-initial-009f-expected.png: Added.
* css2.1/20110323/abspos-containing-block-initial-009f-expected.txt: Added.
* css2.1/20110323/abspos-containing-block-initial-009f.htm: Added.
* css2.1/20110323/height-width-inline-table-001.htm: Added.
* css2.1/20110323/height-width-table-001.htm: Added.
* platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added
* platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added
* platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/height-width-inline-table-001-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/height-width-table-001-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/height-width-table-001-expected.txt: Added.
* platform/gtk/fast/backgrounds/table-root-expected.txt: Removed.
* platform/mac/fast/backgrounds/positioned-root-expected.png: Removed.
* platform/mac/fast/backgrounds/table-root-expected.png: Removed.
* platform/mac/fast/backgrounds/table-root-expected.txt: Removed.
* platform/qt/fast/backgrounds/positioned-root-expected.png: Removed.
* platform/qt/fast/backgrounds/positioned-root-expected.txt: Removed.
* platform/qt/fast/backgrounds/table-root-expected.png: Removed.
* platform/qt/fast/backgrounds/table-root-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
81 files changed:
LayoutTests/ChangeLog
LayoutTests/css2.1/20110323/abspos-containing-block-initial-001-ref.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-001.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004-ref-expected.png [moved from LayoutTests/platform/gtk/fast/backgrounds/positioned-root-expected.png with 98% similarity]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004-ref-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004-ref.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004a-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004a-expected.txt [moved from LayoutTests/platform/gtk/fast/backgrounds/positioned-root-expected.txt with 100% similarity]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004a.htm [moved from LayoutTests/fast/backgrounds/positioned-root.html with 73% similarity]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004b-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004b-expected.txt [moved from LayoutTests/platform/mac/fast/backgrounds/positioned-root-expected.txt with 100% similarity]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004b.htm [moved from LayoutTests/fast/backgrounds/table-root.html with 72% similarity]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004c-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004c-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004c.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004d-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004d-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004d.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004d.htm.1 [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004e-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004e-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004e.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004f-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004f-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-004f.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005-ref-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005-ref-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005-ref.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005a-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005a-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005a.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005b-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005b-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005b.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005c-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005c-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005c.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005d-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005d-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-005d.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-007-ref.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-007.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009-ref-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009-ref-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009-ref.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009a-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009a-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009a.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009b-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009b-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009b.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009e-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009e-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009e.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009f-expected.png [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009f-expected.txt [new file with mode: 0644]
LayoutTests/css2.1/20110323/abspos-containing-block-initial-009f.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/height-width-inline-table-001.htm [new file with mode: 0644]
LayoutTests/css2.1/20110323/height-width-table-001.htm [new file with mode: 0644]
LayoutTests/platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.png [moved from LayoutTests/platform/gtk/fast/backgrounds/table-root-expected.png with 55% similarity]
LayoutTests/platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png [new file with mode: 0644]
LayoutTests/platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.png [new file with mode: 0644]
LayoutTests/platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png [new file with mode: 0644]
LayoutTests/platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-linux/css2.1/20110323/height-width-inline-table-001-expected.png [new file with mode: 0644]
LayoutTests/platform/chromium-linux/css2.1/20110323/height-width-inline-table-001-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-linux/css2.1/20110323/height-width-table-001-expected.png [new file with mode: 0644]
LayoutTests/platform/chromium-linux/css2.1/20110323/height-width-table-001-expected.txt [new file with mode: 0644]
LayoutTests/platform/gtk/fast/backgrounds/table-root-expected.txt [deleted file]
LayoutTests/platform/mac/fast/backgrounds/positioned-root-expected.png [deleted file]
LayoutTests/platform/mac/fast/backgrounds/table-root-expected.png [deleted file]
LayoutTests/platform/mac/fast/backgrounds/table-root-expected.txt [deleted file]
LayoutTests/platform/qt/fast/backgrounds/positioned-root-expected.png [deleted file]
LayoutTests/platform/qt/fast/backgrounds/positioned-root-expected.txt [deleted file]
LayoutTests/platform/qt/fast/backgrounds/table-root-expected.png [deleted file]
LayoutTests/platform/qt/fast/backgrounds/table-root-expected.txt [deleted file]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderTable.cpp