2011-01-10 Martin Robinson <mrobinson@igalia.com>
authormrobinson@webkit.org <mrobinson@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 10 Jan 2011 22:04:57 +0000 (22:04 +0000)
committermrobinson@webkit.org <mrobinson@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 10 Jan 2011 22:04:57 +0000 (22:04 +0000)
commit71ff265832dc1818449ea40f3a3a1aa1bc7150af
tree05301dcf4de8fd4e0d1f3b37a122daa8c80e1675
parent8bd60ffe7d8c39cdb17cab8ae21cacb03e325d0a
2011-01-10  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Remove unecessary RenderThemeGtk and WidgetRenderingContext code
        https://bugs.webkit.org/show_bug.cgi?id=52170

        Remove unnecessary code from RenderThemeGtk3 and RenderThemeGtk now that the
        GtkStyleContext port is complete. Also remove WidgetRenderingContextGtk3 and
        move WidgetRenderingRenderingContextGtk2 to WidgetRenderingContext and make it
        GTK+ 2.x only. Some methods have been moved to RenderThemeGtk2 since they are
        GTK+ 2.x only now.

        No new tests. This should not change functionality.

        * GNUmakefile.am: Remove WidgetRenderingContextGtk3 and gtk3drawing.c
        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::RenderThemeGtk):
        (WebCore::gtkIconState): Made this method static. It isn't used outside RenderThemeGtk.
        (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): Updated to refelct gtkIconState change.
        (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): Ditto.
        (WebCore::RenderThemeGtk::paintMediaButton): Ditto
        * platform/gtk/RenderThemeGtk.h: Move a few methods which are now GTK+ 2.x only.
        * platform/gtk/RenderThemeGtk2.cpp:
        (WebCore::RenderThemeGtk::platformInit): Added this platform initialization method
        that is only used for GTK+ 2.x at the moment.
        (WebCore::RenderThemeGtk::~RenderThemeGtk): Added.
        (WebCore::getGtkStateType): Made this method static.
        (WebCore::RenderThemeGtk::getIndicatorMetrics): Moved this here from RenderThemeGtk.
        (WebCore::setToggleSize): Updated to reflect changes to getGtkStateType.
        (WebCore::RenderThemeGtk::paintButton): Ditto.
        (WebCore::RenderThemeGtk::paintSliderTrack): Ditto.
        (WebCore::RenderThemeGtk::paintSliderThumb): Ditto.
        * platform/gtk/RenderThemeGtk3.cpp:
        (WebCore::RenderThemeGtk::gtkScrollbarStyle): Moved to the top of the file.
        (WebCore::RenderThemeGtk::platformInit): Added.
        (WebCore::RenderThemeGtk::~RenderThemeGtk): Added.
        (WebCore::RenderThemeGtk::initMediaColors): Changed to use the GtkStyleContext API to
        fetch these colors. This was the last dependency on the old API.
        * platform/gtk/WidgetRenderingContext.cpp: Renamed from Source/WebCore/platform/gtk/WidgetRenderingContextGtk2.cpp.
        * platform/gtk/WidgetRenderingContext.h: Made GTK+ 2.x only.
        * platform/gtk/WidgetRenderingContextGtk3.cpp: Removed.
        * platform/gtk/gtk3drawing.c: Removed.
        * platform/gtk/gtkdrawing.h: Made GTK+ 2.x only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/GNUmakefile.am
Source/WebCore/platform/gtk/RenderThemeGtk.cpp
Source/WebCore/platform/gtk/RenderThemeGtk.h
Source/WebCore/platform/gtk/RenderThemeGtk2.cpp
Source/WebCore/platform/gtk/RenderThemeGtk3.cpp
Source/WebCore/platform/gtk/WidgetRenderingContext.cpp [moved from Source/WebCore/platform/gtk/WidgetRenderingContextGtk2.cpp with 100% similarity]
Source/WebCore/platform/gtk/WidgetRenderingContext.h
Source/WebCore/platform/gtk/WidgetRenderingContextGtk3.cpp [deleted file]
Source/WebCore/platform/gtk/gtk3drawing.c [deleted file]
Source/WebCore/platform/gtk/gtkdrawing.h