Multiple (stacked) cues when shuttling through video while playing closed captions
authorbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 9 May 2014 05:20:59 +0000 (05:20 +0000)
committerbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 9 May 2014 05:20:59 +0000 (05:20 +0000)
commit719660b1381e740c2364f1a2edd7d19d86a0d1ac
treeb57890ecc2f6e3c4d191f82e7e13241883ff92d7
parente72880ca833d44931cd6d70a9eda7faedabcab50
Multiple (stacked) cues when shuttling through video while playing closed captions
https://bugs.webkit.org/show_bug.cgi?id=132715
<rdar://problem/16795782>

Reviewed by Eric Carlson.

Tests: media/track/track-in-band-cues-added-once.html

* html/track/TextTrack.cpp:
(WebCore::TextTrack::hasCue): Revise to use a relaxed time equality.
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::isEqual): Ditto.
(WebCore::TextTrackCue::hasEquivalentStartTime): Added.
* html/track/TextTrackCue.h:
(WebCore::TextTrackCue::startTimeVariance): Added.
* html/track/TextTrackCueGeneric.h:
* html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::isEqual): Do not call the VTTCue::isEqual method from
this class, since cueType() will not equal VTTCue, and the equality will fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/html/track/TextTrack.cpp
Source/WebCore/html/track/TextTrackCue.cpp
Source/WebCore/html/track/TextTrackCue.h
Source/WebCore/html/track/TextTrackCueGeneric.cpp
Source/WebCore/html/track/TextTrackCueGeneric.h