Ruby overhang uses ints instead of floats
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 16 Dec 2014 22:53:19 +0000 (22:53 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 16 Dec 2014 22:53:19 +0000 (22:53 +0000)
commit715e2ec6f8cb70b57136c1e520290724e22491c7
tree09906505f8fca16de25517f8f34df042c730eb3a
parent18e1b883ef5bdf4d068f69ae5e06888ca18f45f6
Ruby overhang uses ints instead of floats
https://bugs.webkit.org/show_bug.cgi?id=139624

Reviewed by Dave Hyatt.

Source/WebCore:

Simply change the type.

Updated existing tests.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::setMarginsForRubyRun):
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::getOverhang):
* rendering/RenderRubyRun.h:
* rendering/line/LineWidth.cpp:
(WebCore::LineWidth::applyOverhang):

LayoutTests:

Updating tests.

* fast/ruby/overhang-horizontal-expected.png:
* fast/ruby/overhang-horizontal-expected.txt:
* fast/ruby/overhang-vertical-expected.png:
* fast/ruby/overhang-vertical-expected.txt:
* platform/mac/fast/ruby/ruby-beforeafter-expected.png:
* platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
* platform/mac/fast/ruby/ruby-length-expected.png:
* platform/mac/fast/ruby/ruby-length-expected.txt:
* platform/mac/fast/ruby/ruby-run-break-expected.png:
* platform/mac/fast/ruby/ruby-run-break-expected.txt:
* platform/mac/fast/ruby/ruby-runs-expected.png:
* platform/mac/fast/ruby/ruby-runs-expected.txt:
* platform/mac/fast/ruby/ruby-runs-spans-expected.png:
* platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
* platform/mac/fast/ruby/ruby-trailing-expected.png:
* platform/mac/fast/ruby/ruby-trailing-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png:
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png:
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png:
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt:
* platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
38 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/ruby/overhang-horizontal-expected.png
LayoutTests/fast/ruby/overhang-horizontal-expected.txt
LayoutTests/fast/ruby/overhang-vertical-expected.png
LayoutTests/fast/ruby/overhang-vertical-expected.txt
LayoutTests/platform/mac/fast/ruby/ruby-beforeafter-expected.png
LayoutTests/platform/mac/fast/ruby/ruby-beforeafter-expected.txt
LayoutTests/platform/mac/fast/ruby/ruby-length-expected.png
LayoutTests/platform/mac/fast/ruby/ruby-length-expected.txt
LayoutTests/platform/mac/fast/ruby/ruby-run-break-expected.png
LayoutTests/platform/mac/fast/ruby/ruby-run-break-expected.txt
LayoutTests/platform/mac/fast/ruby/ruby-runs-expected.png
LayoutTests/platform/mac/fast/ruby/ruby-runs-expected.txt
LayoutTests/platform/mac/fast/ruby/ruby-runs-spans-expected.png
LayoutTests/platform/mac/fast/ruby/ruby-runs-spans-expected.txt
LayoutTests/platform/mac/fast/ruby/ruby-trailing-expected.png
LayoutTests/platform/mac/fast/ruby/ruby-trailing-expected.txt
LayoutTests/platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png
LayoutTests/platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt
LayoutTests/platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png
LayoutTests/platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt
LayoutTests/platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png
LayoutTests/platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt
LayoutTests/platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png
LayoutTests/platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt
LayoutTests/platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png
LayoutTests/platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt
LayoutTests/platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png
LayoutTests/platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt
LayoutTests/platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png
LayoutTests/platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt
LayoutTests/platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png
LayoutTests/platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBlockLineLayout.cpp
Source/WebCore/rendering/RenderRubyRun.cpp
Source/WebCore/rendering/RenderRubyRun.h
Source/WebCore/rendering/line/LineWidth.cpp