[ContentChangeObserver] Stop using the global _WKContentChange
authorzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Mar 2019 19:05:27 +0000 (19:05 +0000)
committerzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Mar 2019 19:05:27 +0000 (19:05 +0000)
commit6fcd3fff3eaa141416635031a26332632e0a2783
tree7ff2725cec0bcd66e1288739a6182880615f75ea
parent2c35f32768ebdfe3f9ebbf263468a351ceb0d947
[ContentChangeObserver] Stop using the global _WKContentChange
https://bugs.webkit.org/show_bug.cgi?id=196288
<rdar://problem/49228081>

Reviewed by Simon Fraser.

Source/WebCore:

This patch ensures that activities on frames don't overwrite the observed state on other frames.
(Unfortunately the global variable is still used in WebKitLegacy (see webkit.org/b/196286)).

Tests: fast/events/touch/ios/content-observation/remove-subframe-while-observing.html
       fast/events/touch/ios/content-observation/subframe.html

* page/ios/ContentChangeObserver.cpp:
(WebCore::ContentChangeObserver::observedContentChange const): Deleted.
* page/ios/ContentChangeObserver.h:
(WebCore::ContentChangeObserver::observedContentChange const):
(WebCore::ContentChangeObserver::setHasNoChangeState):
(WebCore::ContentChangeObserver::setHasIndeterminateState):
(WebCore::ContentChangeObserver::setHasVisibleChangeState):
(WebCore::ContentChangeObserver::setObservedContentState):

LayoutTests:

* fast/events/touch/ios/content-observation/remove-subframe-while-observing-expected.txt: Added.
* fast/events/touch/ios/content-observation/remove-subframe-while-observing.html: Added.
* fast/events/touch/ios/content-observation/subframe.html: Added.
* platform/ios-device-wk1/TestExpectations:
* platform/ios-simulator-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/events/touch/ios/content-observation/remove-subframe-while-observing-expected.txt [new file with mode: 0644]
LayoutTests/fast/events/touch/ios/content-observation/remove-subframe-while-observing.html [new file with mode: 0644]
LayoutTests/fast/events/touch/ios/content-observation/subframe.html [new file with mode: 0644]
LayoutTests/platform/ios-device-wk1/TestExpectations
LayoutTests/platform/ios-simulator-wk1/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/page/ios/ContentChangeObserver.cpp
Source/WebCore/page/ios/ContentChangeObserver.h