[Qt] Fix focus ring outline color support
authoryael.aharon@nokia.com <yael.aharon@nokia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 6 Dec 2010 14:33:39 +0000 (14:33 +0000)
committeryael.aharon@nokia.com <yael.aharon@nokia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 6 Dec 2010 14:33:39 +0000 (14:33 +0000)
commit6f32f294c34e29f3012badff6fca9b42dc707839
treea9b17a404885e40e360ed2078269c34ebce10355
parentf45846500b3a7a9ef434e35cc98a115ffea9afc8
[Qt] Fix focus ring outline color support
https://bugs.webkit.org/show_bug.cgi?id=50325

Reviewed by Andreas Kling.

WebCore:

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawFocusRing):

Take the outline width into account when drawing the focus ring of image map.
Change the outline-style from dotted to solid. The default outline-width is
5 pixels, and dotted lines just don't make sense anymore.
Give the focus ring alpha of 50%, following what other ports do.
Save and restore the pen when drawing a focus ring.

LayoutTests:

* platform/qt/Skipped:
* platform/qt/fast/images/imagemap-focus-ring-expected.checksum:
* platform/qt/fast/images/imagemap-focus-ring-expected.png:
* platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.checksum: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.checksum: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.checksum: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
* platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
* platform/qt/fast/images/imagemap-focus-ring-zoom-expected.checksum:
* platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
17 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/qt/Skipped
LayoutTests/platform/qt/fast/images/imagemap-focus-ring-expected.checksum
LayoutTests/platform/qt/fast/images/imagemap-focus-ring-expected.png
LayoutTests/platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.checksum [new file with mode: 0644]
LayoutTests/platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.png [new file with mode: 0644]
LayoutTests/platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.txt [new file with mode: 0644]
LayoutTests/platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.checksum [new file with mode: 0644]
LayoutTests/platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png [new file with mode: 0644]
LayoutTests/platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt [new file with mode: 0644]
LayoutTests/platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.checksum [new file with mode: 0644]
LayoutTests/platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png [new file with mode: 0644]
LayoutTests/platform/qt/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt [new file with mode: 0644]
LayoutTests/platform/qt/fast/images/imagemap-focus-ring-zoom-expected.checksum
LayoutTests/platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png
WebCore/ChangeLog
WebCore/platform/graphics/qt/GraphicsContextQt.cpp