LayoutTests:
authorddkilzer <ddkilzer@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 14 Apr 2007 01:26:07 +0000 (01:26 +0000)
committerddkilzer <ddkilzer@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 14 Apr 2007 01:26:07 +0000 (01:26 +0000)
commit6ed7a283f294c489c3939d17be3bb04fb5ba0c00
tree9626e97a82b3f735ac481c03c4b1d7492bacd2b8
parent4caf8c508ab19541f7df4e2d234acd10450f6cb9
LayoutTests:

        Patch and review by hyatt.  Testing and landing by ddkilzer.

        <rdar://problem/5078866>
        tables don't inherit text-align (in strict mode; they're not supposed to in quirks mode)

        Test tables/mozilla_expected_failures/bugs/bug11384s.html progressed after this fix, so
        it was moved to tables/mozilla/bugs/bug11384s.html.

        * fast/css/table-text-align-quirk-expected.checksum: Added.
        * fast/css/table-text-align-quirk-expected.png: Added.
        * fast/css/table-text-align-quirk-expected.txt: Added.
        * fast/css/table-text-align-quirk.html: Added.
        * fast/css/table-text-align-strict-expected.checksum: Added.
        * fast/css/table-text-align-strict-expected.png: Added.
        * fast/css/table-text-align-strict-expected.txt: Added.
        * fast/css/table-text-align-strict.html: Added.
        * fast/table/border-collapsing/rtl-border-collapsing.html: Replaced "text-align: -khtml-center"
        style with "text-align: center" style.
        * tables/mozilla/bugs/bug11384s-expected.checksum: Added.
        * tables/mozilla/bugs/bug11384s-expected.png: Added.
        * tables/mozilla/bugs/bug11384s-expected.txt: Added.
        * tables/mozilla/bugs/bug11384s.html: Added.
        * tables/mozilla_expected_failures/bugs/bug11384s-expected.checksum: Removed.
        * tables/mozilla_expected_failures/bugs/bug11384s-expected.png: Removed.
        * tables/mozilla_expected_failures/bugs/bug11384s-expected.txt: Removed.
        * tables/mozilla_expected_failures/bugs/bug11384s.html: Removed.

WebCore:

        Patch and review by hyatt.  Testing and landing by ddkilzer.

        <rdar://problem/5078866>
        tables don't inherit text-align (in strict mode; they're not supposed to in quirks mode)

        Test: fast/css/table-text-align-quirk.html
              fast/css/table-text-align-strict.html

        Previous commit (r20731) removed the wrong property from WebCore/css/html4.css.  However,
        when the correct property was removed, it caused tables to inherit alignment properties
        from tags like <center> and <div align="center">.  This is fixed in
        WebCore::CSSStyleSelector::adjustRenderStyle() by special-casing tables to reset the
        text-align property.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForTextAlign): Renamed KHTML_CENTER, KHTML_LEFT and KHTML_RIGHT to
        WEBKIT_CENTER, WEBKIT_LEFT and WEBKIT_RIGHT.
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue): Ditto.
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle): Tables should not support -webkit-center,
        -webkit-left or -webkit-right values for text-align, so reset them back to auto.
        * css/html4.css: Removed "text-align: -webkit-auto;" property from tables selector.  It
        was previously added to css/quirks.css in r20731.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::determineHorizontalPosition): Renamed KHTML_* to WEBKIT_*.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcHorizontalMargins): Ditto.
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::caretRect): Ditto.
        * rendering/RenderStyle.h: Ditto.
        (WebCore::):
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
26 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/css/table-text-align-quirk-expected.checksum [new file with mode: 0644]
LayoutTests/fast/css/table-text-align-quirk-expected.png [new file with mode: 0644]
LayoutTests/fast/css/table-text-align-quirk-expected.txt [new file with mode: 0644]
LayoutTests/fast/css/table-text-align-quirk.html [new file with mode: 0644]
LayoutTests/fast/css/table-text-align-strict-expected.checksum [new file with mode: 0644]
LayoutTests/fast/css/table-text-align-strict-expected.png [new file with mode: 0644]
LayoutTests/fast/css/table-text-align-strict-expected.txt [new file with mode: 0644]
LayoutTests/fast/css/table-text-align-strict.html [new file with mode: 0644]
LayoutTests/fast/table/border-collapsing/rtl-border-collapsing.html
LayoutTests/tables/mozilla/bugs/bug11384s-expected.checksum [new file with mode: 0644]
LayoutTests/tables/mozilla/bugs/bug11384s-expected.png [new file with mode: 0644]
LayoutTests/tables/mozilla/bugs/bug11384s-expected.txt [moved from LayoutTests/tables/mozilla_expected_failures/bugs/bug11384s-expected.txt with 80% similarity]
LayoutTests/tables/mozilla/bugs/bug11384s.html [moved from LayoutTests/tables/mozilla_expected_failures/bugs/bug11384s.html with 100% similarity]
LayoutTests/tables/mozilla_expected_failures/bugs/bug11384s-expected.checksum [deleted file]
LayoutTests/tables/mozilla_expected_failures/bugs/bug11384s-expected.png [deleted file]
WebCore/ChangeLog
WebCore/css/CSSComputedStyleDeclaration.cpp
WebCore/css/cssparser.cpp
WebCore/css/cssstyleselector.cpp
WebCore/css/html4.css
WebCore/rendering/RenderBlock.cpp
WebCore/rendering/RenderBox.cpp
WebCore/rendering/RenderFlow.cpp
WebCore/rendering/RenderStyle.h
WebCore/rendering/bidi.cpp