texImage2D for a half-float texture only accepts null
authordino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 Oct 2019 22:29:47 +0000 (22:29 +0000)
committerdino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 Oct 2019 22:29:47 +0000 (22:29 +0000)
commit6c5e5ab3b4e9663b0209de25a409f6fdbf8962a3
treec089d04307a7dfae20630f29266894dd9624094f
parentd919ea7e20b84ec23ab69428016c826ad54f7ae4
texImage2D for a half-float texture only accepts null
https://bugs.webkit.org/show_bug.cgi?id=169999
<rdar://problem/31713571>

Reviewed by Simon Fraser.

Source/WebCore:

After we initially implemented this, the extension was
modified such that texImage2D could upload to half-float
from a Uint16 array.

Test: fast/canvas/webgl/oes-texture-half-float-uint16.html

* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::validateArrayBufferType): Accept
Uint16.

LayoutTests:

Add a new test, and update the expected results of existing tests.

* fast/canvas/webgl/oes-texture-half-float-uint16-expected.txt: Added.
* fast/canvas/webgl/oes-texture-half-float-uint16.html: Added.
* webgl/2.0.0/conformance/extensions/oes-texture-half-float-expected.txt:
* webgl/2.0.0/conformance2/extensions/ext-color-buffer-float-expected.txt:
* webgl/2.0.0/conformance2/textures/misc/tex-new-formats-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
12 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/canvas/webgl/oes-texture-half-float-expected.txt
LayoutTests/fast/canvas/webgl/oes-texture-half-float-uint16-expected.txt [new file with mode: 0644]
LayoutTests/fast/canvas/webgl/oes-texture-half-float-uint16.html [new file with mode: 0644]
LayoutTests/fast/canvas/webgl/oes-texture-half-float.html
LayoutTests/platform/ios-simulator/webgl/2.0.0/conformance2/extensions/ext-color-buffer-float-expected.txt
LayoutTests/platform/ios-simulator/webgl/2.0.0/conformance2/textures/misc/tex-new-formats-expected.txt
LayoutTests/webgl/2.0.0/conformance/extensions/oes-texture-half-float-expected.txt
LayoutTests/webgl/2.0.0/conformance2/extensions/ext-color-buffer-float-expected.txt
LayoutTests/webgl/2.0.0/conformance2/textures/misc/tex-new-formats-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp