[chromium] Convert WebAnimationCurve subtypes into pure virtual
authorjamesr@google.com <jamesr@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Aug 2012 00:36:04 +0000 (00:36 +0000)
committerjamesr@google.com <jamesr@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Aug 2012 00:36:04 +0000 (00:36 +0000)
commit6bfa547fd28a6400d09f146336b3761f47986a1f
tree1c98c5573ae338a694c97f6e2b0d79987c14cece
parent341ab9b81f0b7bf32e4acca56a9d7e3a47b507f9
[chromium] Convert WebAnimationCurve subtypes into pure virtual
https://bugs.webkit.org/show_bug.cgi?id=94068

Reviewed by Adrienne Walker.

Source/Platform:

This makes the Web*AnimationCurve interfaces pure virtual to provide better insulation from the implementation
details of the classes.

* chromium/public/WebAnimation.h:
(WebKit::WebAnimation::WebAnimation):
(WebAnimation):
* chromium/public/WebAnimationCurve.h:
* chromium/public/WebFloatAnimationCurve.h:
(WebFloatAnimationCurve):
(WebKit::WebFloatAnimationCurve::~WebFloatAnimationCurve):
* chromium/public/WebTransformAnimationCurve.h:
(WebTransformAnimationCurve):
(WebKit::WebTransformAnimationCurve::~WebTransformAnimationCurve):

Source/WebCore:

Updates users of the Web*AnimationCurve interface for its new pointery goodness.

* platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::appendKeyframeWithStandardTimingFunction):
(WebCore::appendKeyframeWithCustomBezierTimingFunction):
(WebCore::WebTransformAnimationCurve):
(WebCore::createWebAnimation):

Source/WebKit/chromium:

Updates the implementations, some callers and tests of Web*AnimationCurve to its new interface.

* WebKit.gyp:
* src/WebAnimation.cpp:
(WebKit::WebAnimation::initialize):
* src/WebFloatAnimationCurveImpl.cpp: Renamed from Source/WebKit/chromium/src/WebFloatAnimationCurve.cpp.
(WebKit):
(WebKit::WebFloatAnimationCurve::create):
(WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl):
(WebKit::WebFloatAnimationCurveImpl::~WebFloatAnimationCurveImpl):
(WebKit::WebFloatAnimationCurveImpl::type):
(WebKit::WebFloatAnimationCurveImpl::add):
(WebKit::WebFloatAnimationCurveImpl::getValue):
(WebKit::WebFloatAnimationCurveImpl::cloneToCCAnimationCurve):
* src/WebTransformAnimationCurve.cpp: Removed.
* tests/WebAnimationTest.cpp:
(WebKit::TEST):
* tests/WebFloatAnimationCurveTest.cpp:
(WebKit::TEST):
* tests/WebTransformAnimationCurveTest.cpp:
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
20 files changed:
Source/Platform/ChangeLog
Source/Platform/chromium/public/WebAnimation.h
Source/Platform/chromium/public/WebAnimationCurve.h
Source/Platform/chromium/public/WebFloatAnimationCurve.h
Source/Platform/chromium/public/WebTransformAnimationCurve.h
Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/WebKit.gypi
Source/WebKit/chromium/src/LinkHighlight.cpp
Source/WebKit/chromium/src/WebAnimationImpl.cpp
Source/WebKit/chromium/src/WebAnimationImpl.h
Source/WebKit/chromium/src/WebFloatAnimationCurveImpl.cpp [moved from Source/WebKit/chromium/src/WebFloatAnimationCurve.cpp with 57% similarity]
Source/WebKit/chromium/src/WebFloatAnimationCurveImpl.h [new file with mode: 0644]
Source/WebKit/chromium/src/WebTransformAnimationCurveImpl.cpp [new file with mode: 0644]
Source/WebKit/chromium/src/WebTransformAnimationCurveImpl.h [moved from Source/WebKit/chromium/src/WebTransformAnimationCurve.cpp with 54% similarity]
Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp
Source/WebKit/chromium/tests/WebAnimationTest.cpp
Source/WebKit/chromium/tests/WebFloatAnimationCurveTest.cpp
Source/WebKit/chromium/tests/WebTransformAnimationCurveTest.cpp