Remove unneeded ScriptController::processingUserGesture() forwarding functions
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 23 Nov 2017 19:36:08 +0000 (19:36 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 23 Nov 2017 19:36:08 +0000 (19:36 +0000)
commit6bd3a40f258eb35c8d5bcde5212fda26403b2673
tree1e62d3f49c262708ab0f53e66636c77079ad948f
parent2ddb109fcffc98b36a31541c10d349a0b3c8d5ce
Remove unneeded ScriptController::processingUserGesture() forwarding functions
https://bugs.webkit.org/show_bug.cgi?id=179954

Patch by Sam Weinig <sam@webkit.org> on 2017-11-23
Reviewed by Darin Adler.

Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
with direct calls to the corresponding UserGestureIndicator functions.

Source/WebCore:

* Modules/applepay/ApplePaySession.cpp:
(WebCore::ApplePaySession::create):
(WebCore::ApplePaySession::openPaymentSetup):
* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::speak):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture): Deleted.
(WebCore::ScriptController::processingUserGestureForMedia): Deleted.
* bindings/js/ScriptController.h:
* dom/Document.cpp:
(WebCore::Document::processingUserGestureForMedia const):
* html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::handleDOMActivateEvent):
* html/FileInputType.cpp:
(WebCore::FileInputType::handleDOMActivateEvent):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submitFromJavaScript):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::shouldOpenExternalURLsPolicyToApply):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::allowPopUp):
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):
* page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):

Source/WebKit:

* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::isProcessingUserGesture):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::addResourceRequest):

Source/WebKitLegacy/mac:

* Plugins/WebPluginController.mm:
(-[WebPluginController processingUserGesture]):
* WebView/WebView.mm:
(-[WebView _isProcessingUserGesture]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
20 files changed:
Source/WebCore/ChangeLog
Source/WebCore/Modules/applepay/ApplePaySession.cpp
Source/WebCore/Modules/speech/SpeechSynthesis.cpp
Source/WebCore/bindings/js/ScriptController.cpp
Source/WebCore/bindings/js/ScriptController.h
Source/WebCore/dom/Document.cpp
Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp
Source/WebCore/html/ColorInputType.cpp
Source/WebCore/html/FileInputType.cpp
Source/WebCore/html/HTMLFormElement.cpp
Source/WebCore/html/HTMLPlugInImageElement.cpp
Source/WebCore/loader/FrameLoader.cpp
Source/WebCore/page/DOMWindow.cpp
Source/WebCore/page/PointerLockController.cpp
Source/WebKit/ChangeLog
Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
Source/WebKit/WebProcess/WebPage/WebPage.cpp
Source/WebKitLegacy/mac/ChangeLog
Source/WebKitLegacy/mac/Plugins/WebPluginController.mm
Source/WebKitLegacy/mac/WebView/WebView.mm