Add a runtime-disabled dialog element skeleton
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 17 Jul 2019 18:58:14 +0000 (18:58 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 17 Jul 2019 18:58:14 +0000 (18:58 +0000)
commit685f5837b1e6eca4441fba960a65eacb331c68e0
tree8287d5f44b280f20d3bc78214514e34806d07c48
parent53720d349d85b74bf7b04715b87f6c531a04be10
Add a runtime-disabled dialog element skeleton
https://bugs.webkit.org/show_bug.cgi?id=199839

Patch by Alex Christensen <achristensen@webkit.org> on 2019-07-17
Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

* web-platform-tests/custom-elements/builtin-coverage-expected.txt:
* web-platform-tests/dom/nodes/Node-cloneNode-expected.txt:
* web-platform-tests/html/dom/reflection-misc-expected.txt:
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering-expected.txt:
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt:
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-open-expected.txt:
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt:
* web-platform-tests/html/semantics/interfaces-expected.txt:

Source/WebCore:

Beginning implementation of https://html.spec.whatwg.org/multipage/interactive-elements.html#the-dialog-element
Covered by rebaselining WPT tests.

* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:
* html/HTMLDialogElement.cpp: Added.
(WebCore::HTMLDialogElement::HTMLDialogElement):
(WebCore::HTMLDialogElement::open):
(WebCore::HTMLDialogElement::setOpen):
(WebCore::HTMLDialogElement::returnValue):
(WebCore::HTMLDialogElement::setReturnValue):
(WebCore::HTMLDialogElement::show):
(WebCore::HTMLDialogElement::showModal):
(WebCore::HTMLDialogElement::close):
* html/HTMLDialogElement.h: Added.
* html/HTMLDialogElement.idl: Added.
* html/HTMLTagNames.in:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setDialogElementEnabled):
(WebCore::RuntimeEnabledFeatures::dialogElementEnabled const):

Source/WebKit:

* Shared/WebPreferences.yaml:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetDialogElementEnabled):
(WKPreferencesGetDialogElementEnabled):
* UIProcess/API/C/WKPreferencesRefPrivate.h:
Add SPI to enable the dialog element for tests.

Source/WebKitLegacy/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences dialogElementEnabled]):
(-[WebPreferences setDialogElementEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Add SPI to enable the dialog element for tests.

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
Enable the dialog element for layout tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
35 files changed:
LayoutTests/imported/blink/dialog/inert-node-is-not-highlighted-expected.html
LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt
LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-cloneNode-expected.txt
LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-misc-expected.txt
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering-expected.txt
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-open-expected.txt
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt
Source/WebCore/CMakeLists.txt
Source/WebCore/ChangeLog
Source/WebCore/DerivedSources-input.xcfilelist
Source/WebCore/DerivedSources-output.xcfilelist
Source/WebCore/DerivedSources.make
Source/WebCore/Sources.txt
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/bindings/js/WebCoreBuiltinNames.h
Source/WebCore/html/HTMLDialogElement.cpp [new file with mode: 0644]
Source/WebCore/html/HTMLDialogElement.h [new file with mode: 0644]
Source/WebCore/html/HTMLDialogElement.idl [new file with mode: 0644]
Source/WebCore/html/HTMLTagNames.in
Source/WebCore/page/RuntimeEnabledFeatures.h
Source/WebKit/ChangeLog
Source/WebKit/Shared/WebPreferences.yaml
Source/WebKit/UIProcess/API/C/WKPreferences.cpp
Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
Source/WebKitLegacy/mac/ChangeLog
Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
Source/WebKitLegacy/mac/WebView/WebPreferences.mm
Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
Source/WebKitLegacy/mac/WebView/WebView.mm
Tools/ChangeLog
Tools/DumpRenderTree/mac/DumpRenderTree.mm
Tools/WebKitTestRunner/TestController.cpp