Pass presentational attribute StylePropertySets by const pointer where possible.
authorkling@webkit.org <kling@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 6 Aug 2012 13:14:04 +0000 (13:14 +0000)
committerkling@webkit.org <kling@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 6 Aug 2012 13:14:04 +0000 (13:14 +0000)
commit682ead2250db4db735650a1a70ccb4eb8dca49ef
treec441a8a6a6276b561298be8d7ef242d8c393996b
parentdb885fd9673e7a3b6af96543a18aa71370f23ea4
Pass presentational attribute StylePropertySets by const pointer where possible.
<http://webkit.org/b/93187>

Reviewed by Antti Koivisto.

Minor cleanup to enforce (at compile time) the fact that no methods that have the
side-effect of incurring immutable-to-mutable-StylePropertySet conversion.

This was already covered by assertions, we're just making it stricter and adding
some documentational flavor.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::addElementStyleProperties):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(StyleResolver):
* dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::attributeStyle):
* dom/StyledElement.h:
(WebCore::StyledElement::additionalAttributeStyle):
(StyledElement):
(WebCore::StyledElement::attributeStyle):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::additionalAttributeStyle):
* html/HTMLTableCellElement.h:
(HTMLTableCellElement):
* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::additionalAttributeStyle):
* html/HTMLTableColElement.h:
(HTMLTableColElement):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyle):
(WebCore::HTMLTableElement::additionalCellStyle):
(WebCore::HTMLTableElement::additionalGroupStyle):
* html/HTMLTableElement.h:
(HTMLTableElement):
* html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::additionalAttributeStyle):
* html/HTMLTableSectionElement.h:
(HTMLTableSectionElement):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
14 files changed:
Source/WebCore/ChangeLog
Source/WebCore/css/StyleResolver.cpp
Source/WebCore/css/StyleResolver.h
Source/WebCore/dom/ElementAttributeData.h
Source/WebCore/dom/StyledElement.h
Source/WebCore/html/HTMLTableCellElement.cpp
Source/WebCore/html/HTMLTableCellElement.h
Source/WebCore/html/HTMLTableColElement.cpp
Source/WebCore/html/HTMLTableColElement.h
Source/WebCore/html/HTMLTableElement.cpp
Source/WebCore/html/HTMLTableElement.h
Source/WebCore/html/HTMLTableSectionElement.cpp
Source/WebCore/html/HTMLTableSectionElement.h
Source/WebCore/inspector/InspectorCSSAgent.cpp