Reviewed by John
authorkocienda <kocienda@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 11 Mar 2005 18:43:36 +0000 (18:43 +0000)
committerkocienda <kocienda@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 11 Mar 2005 18:43:36 +0000 (18:43 +0000)
commit6724642f8a4fa40b9ba6daea3885480e5102c3cb
treed6613a40d62eeccd66a52c8568c057ce173bd12f
parentb5c0655f0e0b9c356ba8b7e830d96e17dfa962be
    Reviewed by John

        Fix for this bug:

        <rdar://problem/4045521> Hitting return key with full line selected does not add blank line as it should

        * khtml/editing/htmlediting.cpp:
        (khtml::InsertParagraphSeparatorCommand::doApply): Removed some "special-case" code from this
        function that would look for a selection that started and ended in a different block, and would
        then bail right after the deletion of the selection without inserting a paragraph separator.
        This was just wrong. So, the code change is removal only. When the general-case code runs instead
        of the erroneous special-case code, the bug goes away.

        New tests:

        * layout-tests/editing/inserting/return-key-with-selection-001-expected.txt: Added.
        * layout-tests/editing/inserting/return-key-with-selection-001.html: Added.
        * layout-tests/editing/inserting/return-key-with-selection-002-expected.txt: Added.
        * layout-tests/editing/inserting/return-key-with-selection-002.html: Added.
        * layout-tests/editing/inserting/return-key-with-selection-003-expected.txt: Added.
        * layout-tests/editing/inserting/return-key-with-selection-003.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/editing/inserting/return-key-with-selection-001-expected.txt [new file with mode: 0644]
LayoutTests/editing/inserting/return-key-with-selection-001.html [new file with mode: 0644]
LayoutTests/editing/inserting/return-key-with-selection-002-expected.txt [new file with mode: 0644]
LayoutTests/editing/inserting/return-key-with-selection-002.html [new file with mode: 0644]
LayoutTests/editing/inserting/return-key-with-selection-003-expected.txt [new file with mode: 0644]
LayoutTests/editing/inserting/return-key-with-selection-003.html [new file with mode: 0644]
WebCore/ChangeLog-2005-08-23
WebCore/khtml/editing/htmlediting.cpp