2011-02-23 Abhishek Arya <inferno@chromium.org>
authorinferno@chromium.org <inferno@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 23 Feb 2011 19:03:05 +0000 (19:03 +0000)
committerinferno@chromium.org <inferno@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 23 Feb 2011 19:03:05 +0000 (19:03 +0000)
commit638c88b0fa8e4c78284e188df097153d217e3536
tree7b05f582a64fa30b4eda1733ae5e5e7a70e4a1e7
parent979b516ad863a2da1d7c8adcf27463b1b3feba10
2011-02-23  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Rename a layouttest for conformity. Tests that we do not crash
        when trying to overflow the logical height of a root inline box.
        https://bugs.webkit.org/show_bug.cgi?id=54995

        * fast/overflow/overflow-block-logical-height-crash-expected.txt: Removed.
        * fast/overflow/overflow-block-logical-height-crash.html: Removed.
        * fast/overflow/overflow-height-float-not-removed-crash2-expected.txt: Added.
        * fast/overflow/overflow-height-float-not-removed-crash2.html: Added.
        * fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: Added.
        * fast/overflow/overflow-height-float-not-removed-crash3.html: Added.
2011-02-23  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Make clear float lineboxes resilient against overflows.
        https://bugs.webkit.org/show_bug.cgi?id=54995

        We try to dirty everthing in block range if we have a negative
        logical bottom, or if our logical bottom is less than our logical
        top, or if our logical top is equal to INT_MAX. Plus, we also dirty
        a linebox if its block logical height is less than zero.
        Tests: fast/overflow/overflow-height-float-not-removed-crash2.html
               fast/overflow/overflow-height-float-not-removed-crash3.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeFloatingObject):
        (WebCore::RenderBlock::markLinesDirtyInBlockRange):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::alignBoxesInBlockDirection): remove the hack
        added in r69735. we don't need this anymore since we are making the
        underlying float dirty logic resilient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/overflow/overflow-height-float-not-removed-crash2-expected.txt [moved from LayoutTests/fast/overflow/overflow-block-logical-height-crash-expected.txt with 100% similarity]
LayoutTests/fast/overflow/overflow-height-float-not-removed-crash2.html [moved from LayoutTests/fast/overflow/overflow-block-logical-height-crash.html with 100% similarity]
LayoutTests/fast/overflow/overflow-height-float-not-removed-crash3-expected.txt [new file with mode: 0644]
LayoutTests/fast/overflow/overflow-height-float-not-removed-crash3.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBlock.cpp
Source/WebCore/rendering/RootInlineBox.cpp