[Modern Media Controls] Clicking on the tracks button when the tracks panel is up...
authorgraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 27 Mar 2017 19:44:09 +0000 (19:44 +0000)
committergraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 27 Mar 2017 19:44:09 +0000 (19:44 +0000)
commit61f7ed296e415f594220f46081ff5a0393642e24
treee302abb1a0bb94e23e1ab2900edd9feaaa1d1335
parent63cbc020d9bc40d064388a3b30c60e3ce123a31f
[Modern Media Controls] Clicking on the tracks button when the tracks panel is up in a media document pauses the video
https://bugs.webkit.org/show_bug.cgi?id=168517
<rdar://problem/30577636>

Reviewed by Dean Jackson.

Source/WebCore:

We completely turn off default event handling in MediaDocument.cpp since we're implementing the
behavior we expect to pause and resume the video in the modern-media-controls module already. This
gets rid of this odd case where the content would not see the "click" event while the C++ side would
handle it and pause the video.

* Modules/modern-media-controls/media/media-controller.js:
(MediaController):
(MediaController.prototype.handleEvent):
(MediaController.prototype._containerWasClicked): Deleted.
* html/MediaDocument.cpp:
(WebCore::MediaDocument::defaultEventHandler):

LayoutTests:

* media/video-click-dblckick-standalone.html: We disable modern-media-controls here since we know that this test won't pass with them on.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@214426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/media/video-click-dblckick-standalone.html
Source/WebCore/ChangeLog
Source/WebCore/Modules/modern-media-controls/media/media-controller.js
Source/WebCore/html/MediaDocument.cpp