Makes breakpoints and debugging code during page load work in the
authortimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 5 Oct 2008 04:12:40 +0000 (04:12 +0000)
committertimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 5 Oct 2008 04:12:40 +0000 (04:12 +0000)
commit5bfd337425205175aa428f6218dca510189694ec
tree2db86a69edc9a9c370f85ed78feb326d418f6add
parentb392ed0fbb18b8c4d5bd59812280a654cb7ddbb2
    Makes breakpoints and debugging code during page load work in the
        Web Inspector's debugger. Specifically, this makes the source
        code for loading resources show up in the Scripts panel.

        https://bugs.webkit.org/show_bug.cgi?id=19053
        rdar://problem/5933408

        Reviewed by Mark Rowe.

        * WebCore.xcodeproj/project.pbxproj: Mark the inspector group as
        not using tabs and a tab width of 8.
        * inspector/InspectorController.cpp:
        (WebCore::addResourceSourceToFrame): Return a bool to report if the
        source was added successfully or not.
        (WebCore::addSourceToFrame): Ditto.
        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
        Return early if the InspectorController.addSourceToFrame fails.
        Moved the delete of the _frameNeedsSetup property after that call so
        if the source wasn't added it will be attempted again.
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype.detach): Move a comment.
        (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
        Don't check if the resource is finished or failed, just attempt
        to add the source to the frame. WebCore has the source, but the
        finished property hasn't been set yet. Return early if the
        InspectorController.addSourceToFrame fails. Moved the delete
        of the _frameNeedsSetup property after that call so if the source
        wasn't added it will be attempted again.
        (WebInspector.SourceView.prototype._resourceLoadingFinished):
        Clear the _frameNeedsSetup and _sourceFrameSetup properties so
        the source frame will we populated again now that the resource
        load has finished.
        * manual-tests/inspector/debugger-pause-during-load.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore/ChangeLog
WebCore/WebCore.xcodeproj/project.pbxproj
WebCore/inspector/InspectorController.cpp
WebCore/inspector/front-end/ScriptView.js
WebCore/inspector/front-end/SourceView.js
WebCore/manual-tests/inspector/debugger-pause-during-load.html [new file with mode: 0644]