WebCore:
authoradele <adele@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 30 Jan 2007 00:15:39 +0000 (00:15 +0000)
committeradele <adele@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 30 Jan 2007 00:15:39 +0000 (00:15 +0000)
commit5b0fca3a317b7b4de2981626af80fbe18deb061e
tree0e8a853b8643360c89f8564d6326269ec6e4db73
parentf30ab246256029d9f9a11585d76d91833d62212c
WebCore:

        Reviewed by Darin.

        More preparation for event handling fixes.

        * bridge/EditorClient.h: Removed EventTargetNode parameter from handleKeyPress since we can just get that from the event.
        * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): ditto.
        * page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): ditto.
        * page/EventHandler.h: ditto.
        * platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::handleKeyPress): ditto.

        * editing/Editor.h:
        * editing/Editor.cpp:
        (WebCore::Editor::handleKeyPress): Removed EventTargetNode parameter.
        (WebCore::Editor::execCommand): Made commandMap use AtomicStringImpls instead of Strings.
        (WebCore::Editor::insertText): Moved from the bridge.

        * page/mac/WebCoreFrameBridge.h: Moved insertText method to Editor.
        * page/mac/WebCoreFrameBridge.mm:

        * WebCore.exp: Updated exports.

WebKit:

        Reviewed by Darin.

        More preparation for event handling fixes.

        * WebCoreSupport/WebEditorClient.h: Removed EventTargetNode parameter, since you can
          just get this from the KeyboardEvent.
        * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): ditto.

        * WebView/WebHTMLViewInternal.h: Added interpretKeyEventsParameters struct.
        * WebView/WebViewInternal.h: Changed parameter from NSEvent to WebCoreKeyboardEvent in _interceptEditingKeyEvent.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView yankAndSelect:]): Updated for new triggeringEvent parameter.
        (-[WebHTMLView _interceptEditingKeyEvent:]): Set the WebHTMLViewInterpretKeyEventsParameters.
        (-[WebHTMLView doCommandBySelector:]): Access WebHTMLViewInterpretKeyEventsParameters.
        (-[WebHTMLView insertText:]): ditto.
        (-[WebHTMLView _insertText:selectInsertedText:triggeringEvent:]): Added parameter for triggeringEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
17 files changed:
WebCore/ChangeLog
WebCore/WebCore.exp
WebCore/bridge/EditorClient.h
WebCore/dom/EventTargetNode.cpp
WebCore/editing/Editor.cpp
WebCore/editing/Editor.h
WebCore/page/EventHandler.cpp
WebCore/page/EventHandler.h
WebCore/page/mac/WebCoreFrameBridge.h
WebCore/page/mac/WebCoreFrameBridge.mm
WebCore/platform/graphics/svg/SVGImageEmptyClients.h
WebKit/ChangeLog
WebKit/WebCoreSupport/WebEditorClient.h
WebKit/WebCoreSupport/WebEditorClient.mm
WebKit/WebView/WebHTMLView.mm
WebKit/WebView/WebHTMLViewInternal.h
WebKit/WebView/WebViewInternal.h