2011-04-28 Abhishek Arya <inferno@chromium.org>
authorinferno@chromium.org <inferno@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 29 Apr 2011 17:20:41 +0000 (17:20 +0000)
committerinferno@chromium.org <inferno@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 29 Apr 2011 17:20:41 +0000 (17:20 +0000)
commit5ab6bc1a82780c759678f3193736b92cd57abebf
tree4770dcb959bbb0fc5b72b098767dc5ad92036c1b
parent9a603963510046286bf883ca00ec8b03a30e88bc
2011-04-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Tests that we do not crash when inline text is removed and we
        try to access layout attributes containing that inline text.
        https://bugs.webkit.org/show_bug.cgi?id=59161

        * svg/text/inline-text-destroy-attributes-crash-expected.txt: Added.
        * svg/text/inline-text-destroy-attributes-crash.xhtml: Added.
2011-04-29  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Nikolas Zimmermann.

        When svg inline text is getting destroyed, make sure to mark
        its svg text ancestor as needing a positioning values update.
        This helps to recalculate layout attributes and makes sure
        that svg inline text is not used again.
        https://bugs.webkit.org/show_bug.cgi?id=59161

        Test: svg/text/inline-text-destroy-attributes-crash.xhtml

        * rendering/svg/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::destroy):
        * rendering/svg/RenderSVGInlineText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/svg/text/inline-text-destroy-attributes-crash-expected.txt [new file with mode: 0644]
LayoutTests/svg/text/inline-text-destroy-attributes-crash.xhtml [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
Source/WebCore/rendering/svg/RenderSVGInlineText.h