Web Inspector: REGRESSION (r187708): Breakpoint dialog script action editing broken
authormattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 3 Aug 2015 22:05:38 +0000 (22:05 +0000)
committermattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 3 Aug 2015 22:05:38 +0000 (22:05 +0000)
commit55d43234e24079480dede2d8ef9038224f061cdd
tree5a9ebdf8831625f7eb36e4ce770669b8033ac441
parent4300debfc0535e7f6e66c08b68300809c2884f54
Web Inspector: REGRESSION (r187708): Breakpoint dialog script action editing broken
https://bugs.webkit.org/show_bug.cgi?id=147553

Reviewed by Joseph Pecoraro.

Passing a widget to CodeMirror.setBookmark generates a viewportChange event, causing the
BreakpointActionView to update the popup for the breakpoint. The spurious update dismisses
the suggestion list, removes the CodeMirror completion hint, and causes other problems.

Now we ignore viewportChange events unless the viewport size changes. We still want to update
the popup when a carriage return or text wrap modifies the viewport.

* UserInterface/Views/BreakpointActionView.js:
(WebInspector.BreakpointActionView.prototype._updateBody):
Evaluate and Probe actions store the current viewport size.
(WebInspector.BreakpointActionView.prototype._codeMirrorViewportChanged):
Check if viewport size has changed since last event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.js