Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 13 Feb 2017 19:58:38 +0000 (19:58 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 13 Feb 2017 19:58:38 +0000 (19:58 +0000)
commit53b72eec3a20c20f2d33e96e0aaf55af8da1b4d5
treec984b631c9e7368480bf9f483fd9ad70ebd78b06
parent4ec44c6248806a050870b2308d849aeca5609292
Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
https://bugs.webkit.org/show_bug.cgi?id=168221

Patch by Fujii Hironori <Hironori.Fujii@sony.com> on 2017-02-13
Reviewed by Ryosuke Niwa.

There is a logic error in comparing mismatch ref test images. In
mismatch ref tests, it should be failed if two images has no diff.
But, if the hashes are different, nwtr unexpectedly pass the
mismatch ref test.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_output_with_reference): Fail the
mismatch ref test if hashes of two images are equal. Invoke
ImageDiff if the hashes don't match.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@212237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Tools/ChangeLog
Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py