Remove CSSCharsetRule from the CSS OM
authorhyatt@apple.com <hyatt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Oct 2016 18:18:09 +0000 (18:18 +0000)
committerhyatt@apple.com <hyatt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Oct 2016 18:18:09 +0000 (18:18 +0000)
commit5347a4c953517b302025065cf924df602f3e53b6
treea0e86f5ce1ed7695b4e7e3b5f81d306074866ca6
parent5183e7246c6348dc3bf8e977f9711d31b379d363
Remove CSSCharsetRule from the CSS OM
https://bugs.webkit.org/show_bug.cgi?id=163891

Reviewed by Darin Adler.

Source/WebCore:

Remove CSSCharsetRule from the CSS OM. All other browser engines have made this
change. This eliminates the weird overloading of isCharsetRule to match both
CSSCharsetRule and StyleRuleCharset (only used by the new parser).

Fix the destroy() method in StyleRuleBase to clean up StyleRuleCharsets created
by the new parser properly.

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJSNewlyCreated):
* css/CSSCharsetRule.cpp: Removed.
* css/CSSCharsetRule.h: Removed.
* css/CSSCharsetRule.idl: Removed.
* css/CSSPropertySourceData.h:
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::rules):
* css/CSSStyleSheet.h:
* css/StyleRule.cpp:
(WebCore::StyleRuleBase::destroy):
* inspector/InspectorStyleSheet.cpp:
(WebCore::asCSSRuleList):

Source/WebKit/mac:

* DOM/DOMCSSCharsetRule.mm:
(-[DOMCSSCharsetRule encoding]):

LayoutTests:

* fast/dom/Window/resources/window-properties.js:
* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:
* fast/encoding/css-charset-default.xhtml:
* fast/encoding/css-charset-dom-expected.txt: Removed.
* fast/encoding/css-charset-dom.html: Removed.
* platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@207767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
29 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/dom/Window/resources/window-properties.js
LayoutTests/fast/dom/dom-constructors-expected.txt
LayoutTests/fast/dom/dom-constructors.html
LayoutTests/fast/encoding/css-charset-default.xhtml
LayoutTests/fast/encoding/css-charset-dom-expected.txt [deleted file]
LayoutTests/fast/encoding/css-charset-dom.html [deleted file]
LayoutTests/http/tests/css/resources/shared-stylesheet-mutation.js
LayoutTests/http/tests/css/shared-stylesheet-mutation-expected.txt
LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt
LayoutTests/platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt
Source/WebCore/CMakeLists.txt
Source/WebCore/ChangeLog
Source/WebCore/DerivedSources.make
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/bindings/js/JSCSSRuleCustom.cpp
Source/WebCore/css/CSSCharsetRule.cpp [deleted file]
Source/WebCore/css/CSSCharsetRule.h [deleted file]
Source/WebCore/css/CSSCharsetRule.idl [deleted file]
Source/WebCore/css/CSSPropertySourceData.h
Source/WebCore/css/CSSStyleSheet.cpp
Source/WebCore/css/CSSStyleSheet.h
Source/WebCore/css/StyleRule.cpp
Source/WebCore/css/StyleRule.h
Source/WebCore/css/StyleSheetContents.cpp
Source/WebCore/css/StyleSheetContents.h
Source/WebCore/inspector/InspectorStyleSheet.cpp
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/DOM/DOMCSSCharsetRule.mm