2010-08-28 Adam Barth <abarth@webkit.org>
authorabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 28 Aug 2010 09:43:48 +0000 (09:43 +0000)
committerabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 28 Aug 2010 09:43:48 +0000 (09:43 +0000)
commit4fbbdc14593e780f74ea466f2c9f380e2ea10206
tree2b9f96e80d67fa6c9e3c3850d33718a3093ad624
parenta5316feec758aeabee4c25850f01224285120215
2010-08-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTMLTreeBuilder needs to call HTMLFormElement::setDemoted
        https://bugs.webkit.org/show_bug.cgi?id=44781

        This patch teaches the HTMLTreeBuilder about demoted form elements.
        Demoting a form element magically stops the form element from
        rendering.  Demoted form elements are a concept from the
        LegacyHTMLTreeBuilder, but they are somewhat of a hack because
        rendering should be DOM-based.  We'll likely look for a better solution
        in a future patch.

        * html/parser/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::insertHTMLFormElement):
        * html/parser/HTMLConstructionSite.h:
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTagForInTable):
2010-08-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTMLTreeBuilder needs to call HTMLFormElement::setDemoted
        https://bugs.webkit.org/show_bug.cgi?id=44781

        Update test expectations to account for demoted form elements.  I spot
        checked a bunch of these and this change is the reverse of the change
        to these expectations in http://trac.webkit.org/changeset/64712.  At
        the time, we thought these rendering changes were correct because the
        DOM was correct.  However, demoted form elements have magical
        non-DOM-based rendering.

        * platform/mac/fast/forms/form-added-to-table-expected.txt:
        * platform/mac/fast/forms/formmove3-expected.txt:
        * platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
        * platform/mac/fast/table/fixed-table-non-cell-in-row-expected.txt:
        * platform/mac/fast/table/inline-form-assert-expected.txt:
        * platform/mac/fast/table/insert-cell-before-form-expected.txt:
        * platform/mac/fast/table/insert-row-before-form-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug2516-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug32447-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug34538-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug96343-expected.txt:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
22 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/mac/fast/forms/form-added-to-table-expected.txt
LayoutTests/platform/mac/fast/forms/formmove3-expected.txt
LayoutTests/platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt
LayoutTests/platform/mac/fast/table/fixed-table-non-cell-in-row-expected.txt
LayoutTests/platform/mac/fast/table/inline-form-assert-expected.txt
LayoutTests/platform/mac/fast/table/insert-cell-before-form-expected.txt
LayoutTests/platform/mac/fast/table/insert-row-before-form-expected.txt
LayoutTests/platform/mac/tables/mozilla/bugs/bug1318-expected.txt
LayoutTests/platform/mac/tables/mozilla/bugs/bug2516-expected.txt
LayoutTests/platform/mac/tables/mozilla/bugs/bug30559-expected.txt
LayoutTests/platform/mac/tables/mozilla/bugs/bug32447-expected.txt
LayoutTests/platform/mac/tables/mozilla/bugs/bug34538-expected.txt
LayoutTests/platform/mac/tables/mozilla/bugs/bug4527-expected.txt
LayoutTests/platform/mac/tables/mozilla/bugs/bug78162-expected.txt
LayoutTests/platform/mac/tables/mozilla/bugs/bug96334-expected.txt
LayoutTests/platform/mac/tables/mozilla/bugs/bug96343-expected.txt
LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt
WebCore/ChangeLog
WebCore/html/parser/HTMLConstructionSite.cpp
WebCore/html/parser/HTMLConstructionSite.h
WebCore/html/parser/HTMLTreeBuilder.cpp