2009-10-07 Brian Weinstein <bweinstein@apple.com>
authorbweinstein@apple.com <bweinstein@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 7 Oct 2009 21:55:58 +0000 (21:55 +0000)
committerbweinstein@apple.com <bweinstein@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 7 Oct 2009 21:55:58 +0000 (21:55 +0000)
commit4cd151347c87cc36e6829d46780ed2a28106c210
tree501ce16a18feddeb060da28e75d5b5ea70a4a566
parent66a5d0bca11808de6536fe4e5b583c5810bf7d7e
2009-10-07  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Timothy Hatcher.

        Fixes <http://webkit.org/b/30104>.
        Inspector should show cookies of sub-resources on the page.

        This function implements showing cookies for all sub-resources of a page.
        When the page is loaded, it populates the Storage Panel with a list of all
        domains that were loaded as part of the full page load (iframes, ads, etc).
        When the user selects one of the domains, the inspector calls back into the
        controller, and the controller combines all of the cookies from that domain
        into a list, and sends that list is sent back to the controller to render.

        A domain now needs to be passed into CookieItemsView, and CookieSidebarTreeElement.

        As a result of a previous patch, we now have detailed cookie information for
        both Windows on CFNetwork and Mac. Additionally, this patch provides deleteCookie
        support on Windows.

        * bindings/js/ScriptObject.cpp:
        (WebCore::ScriptObject::set):
        * bindings/js/ScriptObject.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::getCookies):
        (WebCore::InspectorBackend::deleteCookie):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::getCookies):
        (WebCore::InspectorController::buildArrayForCookies):
        (WebCore::InspectorController::buildObjectForCookie):
        (WebCore::InspectorController::deleteCookie):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addCookieDomainForDocument):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView):
        (WebInspector.CookieItemsView.prototype.update):
        (WebInspector.CookieItemsView.prototype._deleteButtonClicked):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.Cookies.getCookiesAsync):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel):
        (WebInspector.StoragePanel.prototype.reset):
        (WebInspector.StoragePanel.prototype.addCookieDomain):
        (WebInspector.StoragePanel.prototype.showCookies):
        (WebInspector.CookieSidebarTreeElement):
        (WebInspector.CookieSidebarTreeElement.prototype.onselect):
        * inspector/front-end/inspector.js:
        (WebInspector.addCookieDomain):
        * platform/Cookie.h:
        (WebCore::CookieHash::hash):
        (WebCore::CookieHash::equal):
        (WTF::):
        * platform/network/win/CookieJarCFNetWin.cpp:
        (WebCore::deleteCookie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
18 files changed:
WebCore/ChangeLog
WebCore/bindings/js/ScriptObject.cpp
WebCore/bindings/js/ScriptObject.h
WebCore/inspector/InspectorBackend.cpp
WebCore/inspector/InspectorBackend.h
WebCore/inspector/InspectorBackend.idl
WebCore/inspector/InspectorController.cpp
WebCore/inspector/InspectorController.h
WebCore/inspector/InspectorDOMAgent.cpp
WebCore/inspector/InspectorDOMAgent.h
WebCore/inspector/InspectorFrontend.cpp
WebCore/inspector/InspectorFrontend.h
WebCore/inspector/front-end/CookieItemsView.js
WebCore/inspector/front-end/DOMAgent.js
WebCore/inspector/front-end/StoragePanel.js
WebCore/inspector/front-end/inspector.js
WebCore/platform/Cookie.h
WebCore/platform/network/win/CookieJarCFNetWin.cpp