Double tap gesture should send dblclick event
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Aug 2012 23:45:04 +0000 (23:45 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Aug 2012 23:45:04 +0000 (23:45 +0000)
commit4aa700a26c9da0a8785213d3669b58ddffcc8019
tree80435bacddc454662a21bb0278a3553d153a7f78
parentc72a12936acae803b2e952976a83448764d6f012
Double tap gesture should send dblclick event
https://bugs.webkit.org/show_bug.cgi?id=92412

Patch by Rick Byers <rbyers@chromium.org> on 2012-08-03
Reviewed by Adam Barth.

Source/WebCore:

Propagate the tap count from PlatformGestureEvent in the derived mouse
events.

Also fixes a crash with unexpected GestureDoubleTap events by just
supressing them early.  They will probably be removed soon anyway.

Test: fast/events/touch/gesture/gesture-dblclick.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureTap):

Source/WebKit/chromium:

Tweak comment to more completely describe the (lame) overloaded use
of deltaX in WebGestureEvent, and add a FIXME with the bug to track
cleaning it up.
* public/WebInputEvent.h:
(WebGestureEvent):

Tools:

Enable EventSender to set the tap count on tap gesture events.  The
delta X/Y parameters were not actually being used anymore (used to be
used for radius information).

* DumpRenderTree/chromium/TestRunner/EventSender.cpp:
(EventSender::gestureEvent):

LayoutTests:

Adds test for derived mouse events generated by a sequence of two tap
events.  Modeled after gesture-click.html.
* fast/events/touch/gesture/gesture-dblclick-expected.txt: Added.
* fast/events/touch/gesture/gesture-dblclick.html: Added.
* platform/chromium/fast/events/touch/gesture/gesture-dblclick-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/events/touch/gesture/gesture-dblclick-expected.txt [new file with mode: 0644]
LayoutTests/fast/events/touch/gesture/gesture-dblclick.html [new file with mode: 0644]
LayoutTests/platform/chromium/fast/events/touch/gesture/gesture-dblclick-expected.txt [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/page/EventHandler.cpp
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/public/WebInputEvent.h
Tools/ChangeLog
Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp