[iOS] Star rating is covered with a black circle when writing a review on Yelp
authorzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 1 May 2019 20:46:20 +0000 (20:46 +0000)
committerzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 1 May 2019 20:46:20 +0000 (20:46 +0000)
commit4a269a83941f3a73fc3658d5165d12d059f94fe8
treea07dcc32edfc089bbad95bf4ea4b5abb5f10580e
parentd43b27357ba79fc553979a9677c6f322295d28e6
[iOS] Star rating is covered with a black circle when writing a review on Yelp
https://bugs.webkit.org/show_bug.cgi?id=197469
<rdar://problem/48094446>

Reviewed by Dean Jackson.

Source/WebCore:

This patch moves the background painting of the radio/checkbox form controls in checked state to RenderTheme.
It enables content authors to disable default appearance using -webkit-appearance: none (it is also inline with what we do on macOS).

Test: fast/forms/radio-and-checkbox-checked-with-no-appearance.html

* css/html.css:
(input:matches([type="checkbox"], [type="radio"]):checked):
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintCheckboxDecorations):
(WebCore::RenderThemeIOS::paintRadioDecorations):

LayoutTests:

* fast/forms/radio-and-checkbox-checked-with-no-appearance-expected.html: Added.
* fast/forms/radio-and-checkbox-checked-with-no-appearance.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/forms/radio-and-checkbox-checked-with-no-appearance-expected.html [new file with mode: 0644]
LayoutTests/fast/forms/radio-and-checkbox-checked-with-no-appearance.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/css/html.css
Source/WebCore/rendering/RenderThemeIOS.mm