Reviewed by Darin and Oliver.
authormjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 29 Apr 2007 07:33:46 +0000 (07:33 +0000)
committermjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 29 Apr 2007 07:33:46 +0000 (07:33 +0000)
commit481e68e0e671448cd767300c47cde9ef5b29ce85
treec367eb850c5a9ed0603ea7da75fa7e6ce78a2242
parent67d9f1f4a6b84f796e7419ef821cc900bf1a1a23
    Reviewed by Darin and Oliver.

        - change Document to hold onto Frame* instead of FrameView*

        This is an architectural cleanup and a prerequisite to fixing citibank login
        in an architecturally sound way.

        Some fixups for the page cache:

        * history/CachedPage.cpp:
        (WebCore::CachedPage::restore): Add an assert that the document's view
        matches the cached page's view - this needs to be true by the time this
        function is called.
        (WebCore::CachedPage::clear): Change assert to require frame matching, not
        view matching.
        * history/CachedPage.h:
        (WebCore::CachedPage::view): Add a way to get the view out.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::begin): pass Frame, not FrameView, when creating document
        (WebCore::FrameLoader::open): restore view based on CachedPage, not Document.

        Remaining changes are just straightforward updates based on which
        pointer is held or passed:

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):
        (WebCore::DOMImplementation::createHTMLDocument):
        * dom/DOMImplementation.h:
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::view):
        (WebCore::Document::frame):
        (WebCore::Document::recalcStyle):
        (WebCore::Document::updateLayout):
        (WebCore::Document::attach):
        (WebCore::Document::detach):
        (WebCore::Document::createTokenizer):
        (WebCore::Document::recalcStyleSelector):
        (WebCore::Document::setInPageCache):
        (WebCore::Document::applyXSLTransform):
        * dom/Document.h:
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::HTMLDocument):
        * html/HTMLDocument.h:
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
        * html/HTMLViewSourceDocument.h:
        * ksvg2/svg/SVGDocument.cpp:
        (WebCore::SVGDocument::SVGDocument):
        * ksvg2/svg/SVGDocument.h:
        * loader/ImageDocument.cpp:
        (WebCore::ImageDocument::ImageDocument):
        * loader/ImageDocument.h:
        * loader/PluginDocument.cpp:
        (WebCore::PluginDocument::PluginDocument):
        * loader/PluginDocument.h:
        * loader/TextDocument.cpp:
        (WebCore::TextDocument::TextDocument):
        * loader/TextDocument.h:
        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::createDocumentFromSource):
        (WebCore::XSLTProcessor::transformToDocument):
        * xml/XSLTProcessor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
22 files changed:
WebCore/ChangeLog
WebCore/dom/DOMImplementation.cpp
WebCore/dom/DOMImplementation.h
WebCore/dom/Document.cpp
WebCore/dom/Document.h
WebCore/history/CachedPage.cpp
WebCore/history/CachedPage.h
WebCore/html/HTMLDocument.cpp
WebCore/html/HTMLDocument.h
WebCore/html/HTMLViewSourceDocument.cpp
WebCore/html/HTMLViewSourceDocument.h
WebCore/ksvg2/svg/SVGDocument.cpp
WebCore/ksvg2/svg/SVGDocument.h
WebCore/loader/FrameLoader.cpp
WebCore/loader/ImageDocument.cpp
WebCore/loader/ImageDocument.h
WebCore/loader/PluginDocument.cpp
WebCore/loader/PluginDocument.h
WebCore/loader/TextDocument.cpp
WebCore/loader/TextDocument.h
WebCore/xml/XSLTProcessor.cpp
WebCore/xml/XSLTProcessor.h