2011-01-19 Levi Weintraub <leviw@google.com>
authorleviw@chromium.org <leviw@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 Jan 2011 02:03:28 +0000 (02:03 +0000)
committerleviw@chromium.org <leviw@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 Jan 2011 02:03:28 +0000 (02:03 +0000)
commit4794c0dde9b09d2a395b0b0db0d841e9cc096a52
tree624a7b1438eb8dd35c1e1ae8c29bb030876cc7cb
parentf5e4e86211e0961ee7fee6c3a028d2cce80e60c0
2011-01-19  Levi Weintraub  <leviw@google.com>

        Reviewed by Darin Adler.

        Re-committing this with the proper expected results.

        Changing RenderText::localCaretRect to clip to its containing block's logicalLeft and
        logicalRightLayoutOverflow instead of simply using logicalLeft and logicalRight, as this
        resulted in the caret being placed incorrectly in overflowing editable IFrame content.

        Long lines in non-white-space-pre editable documents show cursor in wrong place
        https://bugs.webkit.org/show_bug.cgi?id=48132

        * editing/selection/caret-painting-in-overflowing-autowrap-content.html: Added.
        * editing/selection/resources/iframe-positioning-caret-at-end.html: Added.
        * platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.checksum: Added.
        * platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.png: Added.
        * platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.txt: Added.
2011-01-19  Levi Weintraub  <leviw@google.com>

        Reviewed by Darin Adler.

        Re-committing this with the proper expected results.

        Changing RenderText::localCaretRect to clip to its containing block's logicalLeft and
        logicalRightLayoutOverflow instead of simply using logicalLeft and logicalRight, as this
        resulted in the caret being placed incorrectly in overflowing editable IFrame content.

        Long lines in non-white-space-pre editable documents show cursor in wrong place
        https://bugs.webkit.org/show_bug.cgi?id=48132

        Test: editing/selection/caret-painting-in-overflowing-autowrap-content.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/editing/selection/caret-painting-in-overflowing-autowrap-content.html [new file with mode: 0644]
LayoutTests/editing/selection/resources/iframe-positioning-caret-at-end.html [new file with mode: 0644]
LayoutTests/platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.txt [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderText.cpp